Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for data.azurerm_key_vault_certificate and data.azurerm_key_vault_certificate_data attributes not before and expires #13527

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Add support for data.azurerm_key_vault_certificate and data.azurerm_key_vault_certificate_data attributes not before and expires #13527

merged 2 commits into from
Sep 28, 2021

Conversation

andy-mcgrath
Copy link
Contributor

Data - azurerm_key_vault_certificate, adds attributes expires and not_before dates in RFC3339 format
Data - azurerm_key_vault_certificate_data, adds attribute not_before dates in RFC3339 format

Resolves: #13275

tombuildsstuff
tombuildsstuff approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @andy-mcgrath

@tombuildsstuff tombuildsstuff added this to the v2.79.0 milestone Sep 28, 2021
@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2021-09-28 at 13 51 12

@tombuildsstuff tombuildsstuff merged commit 6e91b9a into hashicorp:main Sep 28, 2021
tombuildsstuff added a commit that referenced this pull request Sep 28, 2021
@tombuildsstuff
updating to include #13527
9c66049
@andy-mcgrath andy-mcgrath deleted the 13275 branch September 28, 2021 13:05
@github-actions
Copy link

github-actions bot commented Oct 1, 2021

This functionality has been released in v2.79.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Nov 1, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/key-vault Key Vault size/M
Projects
None yet
Milestone
v2.79.0
Development

Successfully merging this pull request may close these issues.

Support for data.azurerm_key_vault_certificate exporting certificate not before/not after expiration dates
2 participants
@andy-mcgrath @tombuildsstuff