-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New data source: backup_policy_file_share
#13444
New data source: backup_policy_file_share
#13444
Conversation
backup_policy_file_share
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for he pr @oWretch - overall looks good but have a test failure:
------- Stdout: -------
=== RUN TestAccDataSourceBackupPolicyFileShare_basic
=== PAUSE TestAccDataSourceBackupPolicyFileShare_basic
=== CONT TestAccDataSourceBackupPolicyFileShare_basic
testcase.go:88: Step 1/1 error: Error running pre-apply refresh: exit status 1
Error: Invalid data source
on terraform_plugin_test.tf line 39, in data "azurerm_backup_policy_file_share" "test":
39: data "azurerm_backup_policy_file_share" "test" {
The provider hashicorp/azurerm does not support data source
"azurerm_backup_policy_file_share".
Did you intend to use the managed resource type
"azurerm_backup_policy_file_share"? If so, declare this using a "resource"
block instead of a "data" block.
--- FAIL: TestAccDataSourceBackupPolicyFileShare_basic (2.75s)
FAIL
oh nm looks like you already fixed this since i ran the tests this morning!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @oWretch ! LGTM 🍰
This functionality has been released in v2.80.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Add a data source to pull details of an existing File Share backup policy