Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual Network Service Endpoints for Azure CosmosDB #1342

Closed
idangmic opened this issue Jun 3, 2018 · 4 comments
Closed

Virtual Network Service Endpoints for Azure CosmosDB #1342

idangmic opened this issue Jun 3, 2018 · 4 comments

Comments

@idangmic
Copy link

idangmic commented Jun 3, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Please add the ability to set Virtual Network Service Endpoints for Azure CosmosDB, in addition to the ip_range_filter

also to be able to configure it as a resource (external to the cosmos_db_account)

https://azure.microsoft.com/en-us/blog/virtual-network-service-endpoints-for-azure-cosmos-db-is-now-generally-available/

New or Affected Resource(s)

  • azurerm_cosmos_db_account

Potential Terraform Configuration

resource "azurerm_cosmosdb_account" "db" {
     ....
      vitual_networks = ""
}

resource "azurerm_cosmosdb_firewall_rule" "db_fw" {

}
@test-in-prod
Copy link

Definitely would be useful!

For anyone else looking for the ARM template "crutches" at the moment, ARM has this available via properties:

    "isVirtualNetworkFilterEnabled": true, 
    "virtualNetworkRules": [
      {
        "id": "/subscriptions/guid/resourceGroups/name/providers/Microsoft.Network/virtualNetworks/vnetname/subnets/subnetname"
      }
    ],

@tombuildsstuff tombuildsstuff added this to the Soon milestone Aug 31, 2018
@janlunddk
Copy link

Really looking forward to this feature.
Minor detail :
The resource should probably be called azurerm_cosmosdb_virtual_network_rule, just like the vnet service end point for sql server is called azurerm_sql_virtual_network_rule

@tombuildsstuff
Copy link
Contributor

hey @idgazit @CryptonZylog @janlunddk

Just to let you know that support for this has now landed in v1.16 of the AzureRM Provider (here's the full changelog](https://github.com/terraform-providers/terraform-provider-azurerm/blob/v1.16.0/CHANGELOG.md)). You can upgrade to to this version by specifying it in your provider block:

provider "azurerm" {
  version = "=1.16.0"
}

... and then running terraform init -upgrade :)

Thanks!

@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants