Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_app_service_managed_certificate: Fix for empty issue_date #13357

Merged
merged 1 commit into from
Sep 15, 2021
Merged

azurerm_app_service_managed_certificate: Fix for empty issue_date #13357

merged 1 commit into from
Sep 15, 2021

Conversation

aristosvo
Copy link
Collaborator

@aristosvo aristosvo commented Sep 15, 2021 •
edited
Loading

Fixes #13353
Fixes #13352

Reason

According to Microsoft Azure Support, the following values will be null/empty going forward via API:

  • Thumbprint
  • Issuer
  • IssueDate
  • ExpirationDate

@aristosvo aristosvo changed the title Fix for issue_date azurerm_app_service_managed_certificate: Fix for empty issue_date Sep 15, 2021
jackofallops
jackofallops approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @aristosvo - LGTM 👍

@jackofallops jackofallops added this to the v2.77.0 milestone Sep 15, 2021
@BaraMike BaraMike mentioned this pull request Sep 15, 2021
Closed
@jackofallops jackofallops merged commit a900976 into hashicorp:main Sep 15, 2021
jackofallops added a commit that referenced this pull request Sep 15, 2021
@jackofallops
update for #13357
89f532b
@aristosvo aristosvo deleted the feature/fix-managed-certificate branch September 15, 2021 13:53
@mgzb mgzb mentioned this pull request Sep 15, 2021
Closed
@protoblade protoblade mentioned this pull request Sep 16, 2021
Closed
@github-actions
Copy link

This functionality has been released in v2.77.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@jackofallops jackofallops mentioned this pull request Sep 17, 2021
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2021
@aristosvo aristosvo restored the feature/fix-managed-certificate branch April 14, 2023 07:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackofallops jackofallops jackofallops approved these changes

Assignees
No one assigned
Labels
service/app-service size/XS
Projects
None yet
Milestone
v2.77.0
2 participants
@aristosvo @jackofallops