Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_synapse_sql_pool Allow UTF-8 characters in SQL pool name #13289

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

owenfarrell
Copy link
Contributor

Signed-off-by: Owen Farrell [email protected]<!--- Please keep this note for the community --->

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Summary

This pull request updates the validation logic associated with Synapse SQL pool names to support UTF-8 characters and other non-alphanumeric characters that are supported by Azure.

Fixes: #11554

Output from acceptance testing:

$ make acctests SERVICE='synapse' TESTARGS='-run=TestAccSynapseSqlPool_utf8' TESTTIMEOUT='30m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/synapse -run=TestAccSynapseSqlPool_utf8 -timeout 30m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccSynapseSqlPool_utf8
=== PAUSE TestAccSynapseSqlPool_utf8
=== CONT  TestAccSynapseSqlPool_utf8
--- PASS: TestAccSynapseSqlPool_utf8 (980.83s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/synapse       983.397s

@github-actions github-actions bot added the size/M label Sep 9, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @owenfarrell - LGTM 🏗️

@katbyte katbyte added this to the v2.76.0 milestone Sep 9, 2021
@katbyte katbyte merged commit 9c0d2f8 into hashicorp:main Sep 9, 2021
@katbyte katbyte changed the title Allow UTF-8 characters in SQL pool name azurerm_synapse_sql_pool Allow UTF-8 characters in SQL pool name Sep 9, 2021
katbyte added a commit that referenced this pull request Sep 9, 2021
@github-actions
Copy link

This functionality has been released in v2.76.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@owenfarrell owenfarrell deleted the sql-pool-name branch September 23, 2021 01:29
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect rule for sql pool name validation.
2 participants