-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_logic_app_workflow - support for enabled & access_control #13265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good, just one comment that i will leave inline
@katbyte , thanks for your comments. I've updated code. Please have an another look. Thanks in advance. Note: As service team confirmed they allow setting “OpenAuthenticationAccessPolicy” to only "accessControl.Triggers" for now but other "FlowAccessControlConfigurationPolicy" props like "IpAddressRange" can be set for "accessControl.triggers", "accessControl.contents", "accessControl.actions" and "accessControl.workflowManagement", so I just implemented "allowedCallerIpAddresses" in this PR. I intend to implement "openAuthenticationPolicies" for "accessControl.triggers" once the bug is fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @neil-yechenwei - LGTM now 🏗️
This functionality has been released in v2.77.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR is to add support for new properties
state
andaccessControl
for azurerm_logic_app_workflow.API failed to create Logic App Workflow with "accessControl.triggers". Per the error message, it complains "OpenAuthenticationAccessPolicy.type" should be "AAD" while creating this resource with "accessControl.triggers", which means "OpenAuthenticationAccessPolicy.type" should be writeable. But after checked swagger, I found this property is marked as read-only. Service team confirmed it's a bug in swagger. So I filed an issue on rest api spec and didn't involve it in this PR. Once the bug is fixed, I will submit another PR to add it.
--- PASS: TestAccLogicAppWorkflow_empty (261.74s)
--- PASS: TestAccLogicAppWorkflow_requiresImport (279.18s)
--- PASS: TestAccLogicAppWorkflow_tags (465.55s)
--- PASS: TestAccLogicAppWorkflow_integrationAccount (590.05s)
--- PASS: TestAccLogicAppWorkflow_parameters (240.56s)
--- PASS: TestAccLogicAppWorkflow_accessControl (374.61s)