Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement for postgresql backup instance #13183

Merged
merged 3 commits into from
Sep 2, 2021
Merged

enhancement for postgresql backup instance #13183

merged 3 commits into from
Sep 2, 2021

Conversation

ms-henglu
Copy link
Contributor

@ms-henglu ms-henglu commented Aug 31, 2021 •
edited
Loading

image

@ms-henglu ms-henglu force-pushed the ticket-1865845-enhancement-for-postgresql-backup-instance branch from 26e4786 to e2ed8f9 Compare August 31, 2021 04:49
stephybun
stephybun requested changes Sep 1, 2021
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu. Aside from a few minor comments this is looking good 👍🏼. Since this is my first larger PR review I may ask someone from my team to have a look over this as well.

website/docs/r/data_protection_backup_instance_postgresql.html.markdown Outdated Show resolved Hide resolved
internal/services/dataprotection/data_protection_backup_instance_postgresql_resource.go Show resolved Hide resolved
@ms-henglu
Copy link
Contributor Author

@stephybun , Hi, thanks for code review!

I've updated it according to your suggestions, please take another look, thanks!

@ms-henglu ms-henglu requested a review from stephybun September 1, 2021 09:20
manicminer
manicminer suggested changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ms-henglu, agreed with @stephybun - pending from some minor comments and test results this should be good to merge 👍

internal/services/dataprotection/data_protection_backup_instance_postgresql_resource.go Show resolved Hide resolved
website/docs/r/data_protection_backup_instance_postgresql.html.markdown Outdated Show resolved Hide resolved
@ms-henglu
Copy link
Contributor Author

@manicminer , Hi, thanks for code review.

I've added debug message when conversion failed. And the field supports both key vault secret's id and versionless id, so I've added that to the doc. Thanks!

@ms-henglu ms-henglu requested a review from manicminer September 2, 2021 02:28
@ms-henglu
Copy link
Contributor Author

About the test results, service team is fixing the bug which caused all tests failed. I'll attach a tc results once it got fixed.

@ms-henglu
Copy link
Contributor Author

@manicminer , Hi, tests passed. Could you please take another look, thanks!

manicminer
manicminer approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@manicminer manicminer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu, this LGTM 🔌

Pasting test results:
Screenshot 2021-09-02 at 10 06 08

@manicminer manicminer merged commit 25adf41 into hashicorp:main Sep 2, 2021
@manicminer manicminer added this to the v2.75.0 milestone Sep 2, 2021
manicminer added a commit that referenced this pull request Sep 2, 2021
@manicminer
Changelog for #13183
409d2c1
@github-actions
Copy link

github-actions bot commented Sep 2, 2021

This functionality has been released in v2.75.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 3, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manicminer manicminer manicminer approved these changes

@stephybun stephybun Awaiting requested review from stephybun

Assignees
No one assigned
Labels
documentation enhancement service/data-protection size/L
Projects
None yet
Milestone
v2.75.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ms-henglu @manicminer @stephybun