Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azurerm_synapse_spark_pool to support spark 3.1 instead of 3.0 #13181

Merged
merged 2 commits into from
Sep 2, 2021

Conversation

oguzkilcan
Copy link
Contributor

Azure Synapse now support Apache Spark 3.1 (preview) and support for Spark 3.0 is dropped.

❯ make acctests SERVICE='synapse' TESTARGS='-run=TestAccSynapseSpark3Pool_'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/synapse -run=TestAccSynapseSpark3Pool_ -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccSynapseSpark3Pool_complete
=== PAUSE TestAccSynapseSpark3Pool_complete
=== RUN   TestAccSynapseSpark3Pool_update
=== PAUSE TestAccSynapseSpark3Pool_update
=== CONT  TestAccSynapseSpark3Pool_complete
=== CONT  TestAccSynapseSpark3Pool_update
--- PASS: TestAccSynapseSpark3Pool_complete (1517.20s)
--- PASS: TestAccSynapseSpark3Pool_update (1574.70s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/synapse       1576.160s

@oguzkilcan oguzkilcan changed the title Update azurerm_synapse_spark_pool to support spark 3.1 instead of 3.0 Update azurerm_synapse_spark_pool to support spark 3.1 instead of 3.0 Aug 30, 2021
@katbyte katbyte added this to the v2.75.0 milestone Sep 2, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oguzkilcan - overall looks good but we need to keep the old value around lest we break someones config (even if the API stopped working for old values) - we'll remove it in 3.0

@katbyte katbyte merged commit 82e584d into hashicorp:main Sep 2, 2021
katbyte added a commit that referenced this pull request Sep 2, 2021
@github-actions
Copy link

github-actions bot commented Sep 2, 2021

This functionality has been released in v2.75.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 3, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants