Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_data_factory_dataset_delimited_text - support empty values for the column_delimiter, row_delimiter, quote_character, escape_character, encoding propeties #13149

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

henrymcconville
Copy link
Contributor

The delimited text format treats the changed values differently depending on whether they are omitted or set as empty strings. This PR allows the appropriate values to be set as empty strings as well as being omitted. See: https://docs.microsoft.com/en-us/azure/data-factory/format-delimited-text for documentation.

➜  ~/go/src/github.com/hashicorp/terraform-provider-azurerm: git:(adf-dataset-delimited-fix-pt2) ✗ make acctests SERVICE='datafactory/data_factory_dataset_delimited_text_resource_test.go' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/datafactory/data_factory_dataset_delimited_text_resource_test.go  -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataFactoryDatasetDelimitedText_http
=== PAUSE TestAccDataFactoryDatasetDelimitedText_http
=== RUN   TestAccDataFactoryDatasetDelimitedText_http_update
=== PAUSE TestAccDataFactoryDatasetDelimitedText_http_update
=== RUN   TestAccDataFactoryDatasetDelimitedText_blob_basic
=== PAUSE TestAccDataFactoryDatasetDelimitedText_blob_basic
=== RUN   TestAccDataFactoryDatasetDelimitedText_blob
=== PAUSE TestAccDataFactoryDatasetDelimitedText_blob
=== RUN   TestAccDataFactoryDatasetDelimitedText_blobFS
=== PAUSE TestAccDataFactoryDatasetDelimitedText_blobFS
=== CONT  TestAccDataFactoryDatasetDelimitedText_http
=== CONT  TestAccDataFactoryDatasetDelimitedText_blob
=== CONT  TestAccDataFactoryDatasetDelimitedText_blob_basic
=== CONT  TestAccDataFactoryDatasetDelimitedText_blobFS
=== CONT  TestAccDataFactoryDatasetDelimitedText_http_update
--- PASS: TestAccDataFactoryDatasetDelimitedText_http (94.20s)
--- PASS: TestAccDataFactoryDatasetDelimitedText_blob (104.20s)
--- PASS: TestAccDataFactoryDatasetDelimitedText_blob_basic (111.27s)
--- PASS: TestAccDataFactoryDatasetDelimitedText_blobFS (127.20s)
--- PASS: TestAccDataFactoryDatasetDelimitedText_http_update (141.36s)
PASS
ok  	command-line-arguments	144.400s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @henrymcconville - LGTM 🏗️

@katbyte katbyte added this to the v2.74.0 milestone Aug 26, 2021
@katbyte katbyte added the bug label Aug 26, 2021
@katbyte katbyte changed the title Data Factory Delimited Dataset: Allow empty strings in optional values azurerm_data_factory_dataset_delimited_text - support empty values for the column_delimiter, row_delimiter, quote_character, escape_character, encoding propeties Aug 26, 2021
@katbyte katbyte merged commit 418ae4d into hashicorp:main Aug 26, 2021
katbyte added a commit that referenced this pull request Aug 26, 2021
@henrymcconville henrymcconville deleted the adf-dataset-delimited-fix-pt2 branch August 27, 2021 01:47
@github-actions
Copy link

This functionality has been released in v2.74.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants