Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data_factory_dataset_(binary|delimited_text|json|parquet): Support for dynamic path and filename #13117

Merged
merged 9 commits into from
Aug 26, 2021
Merged

data_factory_dataset_(binary|delimited_text|json|parquet): Support for dynamic path and filename #13117

merged 9 commits into from
Aug 26, 2021

Conversation

aristosvo
Copy link
Contributor

@aristosvo aristosvo commented Aug 24, 2021 •
edited
Loading

Fixes #11650

ToDo

  • Docs

@favoretti
Copy link
Contributor

image

Failures are unrelated.

favoretti
favoretti approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@favoretti favoretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aristosvo, LGTM! 👍🏻

@favoretti
Copy link
Contributor

Oops, too trigger-happy here.. Docs of course :)

@aristosvo
Copy link
Contributor Author

@favoretti Thanks, here we go again 😄

  • Docs added
  • default=false flag based on existing configuration in azurerm_data_factory_dataset_azure_blob
  • Fix for failing AccTest (as discussed)

@aristosvo aristosvo force-pushed the adf-datasets-dynamic-path-filename branch from 11ddbd8 to e6a0ad2 Compare August 24, 2021 13:18
@aristosvo aristosvo force-pushed the adf-datasets-dynamic-path-filename branch from e6a0ad2 to 6c0044a Compare August 24, 2021 13:20
@favoretti
Copy link
Contributor

image

Failure is unrelated, this PR also fixed 2 other failing tests.

@favoretti favoretti added this to the v2.74.0 milestone Aug 25, 2021
katbyte
katbyte approved these changes Aug 26, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌿

@katbyte katbyte merged commit 90d028f into hashicorp:main Aug 26, 2021
katbyte added a commit that referenced this pull request Aug 26, 2021
@katbyte
CHANGELOG.md for #13117
2ae5abc
@aristosvo aristosvo deleted the adf-datasets-dynamic-path-filename branch August 26, 2021 05:21
@github-actions
Copy link

This functionality has been released in v2.74.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021
@aristosvo aristosvo restored the adf-datasets-dynamic-path-filename branch April 14, 2023 07:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@favoretti favoretti favoretti approved these changes

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/cosmosdb size/L
Projects
None yet
Milestone
v2.74.0
3 participants
@aristosvo @favoretti @katbyte