Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_app_service_certificate - introduce argument app_service_plan_id for usage with ASE #13101

Merged

Conversation

haraldatbmw
Copy link
Contributor

This PR introduces the argument app_service_plan_id to the resource azurerm_app_service_certificate and changes the attribute hosting_environment_profile_id to be computed.

The Azure SDK attribute hostingEnvironmentProfile is read-only and was never part of the REST API call for create or update a app_service_certificate.
Azure SDK for go: https://github.com/Azure/azure-sdk-for-go/blob/main/services/web/mgmt/2020-06-01/web/models.go#L7124
Azure REST API: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/web/resource-manager/Microsoft.Web/stable/2020-06-01/Certificates.json#L395

The new argument app_service_plan_id maps to the Azure SDK attribute serverFarmId which is required if an app-service-environment is in place.
Azure REST API: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/web/resource-manager/Microsoft.Web/stable/2020-06-01/Certificates.json#L430

fixes #11771

@haraldatbmw
Copy link
Contributor Author

@jackofallops Please proceed your review here.

@haraldatbmw haraldatbmw requested a review from favoretti August 31, 2021 08:35
@favoretti
Copy link
Collaborator

@haraldatbmw LGTM, still one of the maintainers needs to approve/have a look.

@adamyager
Copy link

@favoretti are you able to approve this? Would be great to have this in the upcoming milestone. This has been broke for some time.

@katbyte katbyte added this to the v2.76.0 milestone Sep 7, 2021
@favoretti
Copy link
Collaborator

@adamyager I'm sorry - I can't. But I see that @katbyte added it to the next release milestone.

@adamyager
Copy link

@adamyager I'm sorry - I can't. But I see that @katbyte added it to the next release milestone.

I do see that. I appreciate it all!

@jackofallops
Copy link
Member

Tests are looking good

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @haraldatbmw - apologies for the delay in approval, this LGTM 👍

@jackofallops jackofallops merged commit e59d4b5 into hashicorp:main Sep 8, 2021
jackofallops added a commit that referenced this pull request Sep 8, 2021
@github-actions
Copy link

This functionality has been released in v2.76.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app_service_certificate not deploying properly and app_service_certificate_binding 404 error
5 participants