Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_private_dns_a_record - fix regression in name validation and add max recordset limit validation #13093

Merged
merged 2 commits into from
Aug 23, 2021

Conversation

jackofallops
Copy link
Member

@jackofallops jackofallops added this to the v2.74.0 milestone Aug 23, 2021
@jackofallops jackofallops requested a review from a team August 23, 2021 08:08
@jackofallops jackofallops self-assigned this Aug 23, 2021
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reverting the validation @jackofallops, LGTM 👍

@jackofallops jackofallops changed the title revert a-name validation and fix max recordset limit azurerm_private_dns_a_record - fix regression in name validation and add max recordset limit validation Aug 23, 2021
@jackofallops jackofallops merged commit c8dd10f into main Aug 23, 2021
@jackofallops jackofallops deleted the b/privatedns-records-max-20 branch August 23, 2021 08:32
jackofallops added a commit that referenced this pull request Aug 23, 2021
@github-actions
Copy link

This functionality has been released in v2.74.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_private_dns_a_record apex records validation bug: Error: "name" cannot contain @
2 participants