Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade network package to 2021-02-01 #13002

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Upgrade network package to 2021-02-01 #13002

merged 1 commit into from
Aug 17, 2021

Conversation

favoretti
Copy link
Collaborator

Fixes #12983

@favoretti
Copy link
Collaborator Author

LB tests pass:
image

@tiwood tiwood mentioned this pull request Aug 16, 2021
Closed
@favoretti
Copy link
Collaborator Author

FW tests pass:
image

@favoretti
Copy link
Collaborator Author

Network tests pass (failures are unrelated or not relevant):
image

favoretti
favoretti commented Aug 16, 2021
View reviewed changes
internal/services/network/virtual_network_peering_resource.go
@@ -226,7 +226,7 @@ func retryVnetPeeringsClientCreateUpdate(d *pluginsdk.ResourceData, resGroup str
ctx, cancel := timeouts.ForCreateUpdate(meta.(*clients.Client).StopContext, d)
defer cancel()

future, err := vnetPeeringsClient.CreateOrUpdate(ctx, resGroup, vnetName, name, peer)
future, err := vnetPeeringsClient.CreateOrUpdate(ctx, resGroup, vnetName, name, peer, network.SyncRemoteAddressSpaceTrue)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only available option for now, so decided not to make it into a parameter for now.

@katbyte katbyte added this to the v2.73.0 milestone Aug 17, 2021
katbyte
katbyte approved these changes Aug 17, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @favoretti - LGTM 🏗️

@katbyte katbyte merged commit ad46e90 into hashicorp:main Aug 17, 2021
katbyte added a commit that referenced this pull request Aug 17, 2021
@katbyte
CHANGELOG.md for #13002
09dec20
@github-actions
Copy link

This functionality has been released in v2.73.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
dependencies size/XL
Projects
None yet
Milestone
v2.73.0
Development

Successfully merging this pull request may close these issues.

Support new resource of Custom IP prefix
2 participants
@favoretti @katbyte