Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_network_security_group - the protocol property now supports Ah and Esp values #12865

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

gwellington
Copy link

#11581 adds the new Esp and Ah protocols to the network security group rules, but misses adding it to the network security group as well.

This PR should true up the existing protocols for NSGs with NSRs

hashicorp#11581 adds the new Esp and Ah protocols to the network security group rules, but misses adding it to the network security group as well.

This PR should true up the existing protocols for NSGs with NSRs
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gwellington - LGTM 🍕

@katbyte katbyte added this to the v2.71.0 milestone Aug 5, 2021
@katbyte katbyte merged commit ccf5e58 into hashicorp:master Aug 5, 2021
@katbyte katbyte changed the title Network Security Group | True Up Protocols azurerm_network_security_group - the protocol property now supports Ah and Esp values Aug 5, 2021
katbyte added a commit that referenced this pull request Aug 5, 2021
@gwellington gwellington deleted the nsg-protocol-trueup branch August 5, 2021 23:02
@github-actions
Copy link

github-actions bot commented Aug 6, 2021

This functionality has been released in v2.71.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 6, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants