Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notificationhubs: switching to use ID Formatters #12845

Merged
merged 8 commits into from
Aug 5, 2021

Conversation

tombuildsstuff
Copy link
Contributor

This PR supersedes #12648 and fixes #11602 by introducing ID Formatters for the Notification Hubs resources and adding a state migration to ensure these are consistent.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor Author

Confirmed the state migrations look good 👍

@tombuildsstuff tombuildsstuff marked this pull request as ready for review August 5, 2021 07:46
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

Screenshot 2021-08-05 at 10 38 41

@tombuildsstuff tombuildsstuff merged commit d11f9e0 into master Aug 5, 2021
@tombuildsstuff tombuildsstuff deleted the b/notification-hubs branch August 5, 2021 08:38
tombuildsstuff added a commit that referenced this pull request Aug 5, 2021
@github-actions
Copy link

github-actions bot commented Aug 6, 2021

This functionality has been released in v2.71.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 6, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ID was missing the notificationHubs element not error while running plan and apply
2 participants