-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubernetes_cluster supports maintenance_config #12762
kubernetes_cluster supports maintenance_config #12762
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THis is causing all tests to fail:
------- Stdout: -------
=== RUN TestAccKubernetesCluster_privateClusterOnWithPrivateDNSZoneSubDomain
=== PAUSE TestAccKubernetesCluster_privateClusterOnWithPrivateDNSZoneSubDomain
=== CONT TestAccKubernetesCluster_privateClusterOnWithPrivateDNSZoneSubDomain
testcase.go:88: Step 1/1 error: Error running apply: exit status 1
Error: retrieving Maintenance Configuration for Managed Kubernetes Cluster ("Cluster: (Managed Cluster Name \"acctestaks210730050729703273\" / Resource Group \"acctestRG-aks-210730050729703273\")"): containerservice.MaintenanceConfigurationsClient#Get: Failure responding to request: StatusCode=404 -- Original Error: autorest/azure: Service returned an error. Status=404 Code="NotFound" Message="Could not find the maintenance configuration: default in subscription: *******, resourceGroup: acctestRG-aks-210730050729703273, resourceName: acctestaks210730050729703273."
with azurerm_kubernetes_cluster.test,
on terraform_plugin_test.tf line 28, in resource "azurerm_kubernetes_cluster" "test":
28: resource "azurerm_kubernetes_cluster" "test" {
--- FAIL: TestAccKubernetesCluster_privateClusterOnWithPrivateDNSZoneSubDomain (1021.31s)
FAIL
0a3fb3a
to
3387a92
Compare
@katbyte , Hi, I've updated the commit, could you please take another look? Thanks! |
azurerm/internal/services/containers/kubernetes_cluster_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/containers/kubernetes_cluster_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/containers/kubernetes_cluster_resource.go
Outdated
Show resolved
Hide resolved
@katbyte , thanks! I've added a commit to rename the fields according to your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @ms-henglu - LGTM 🚀
This functionality has been released in v2.71.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
rewrite #12305, embed maintenance resource to kubernetes_cluster