Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes_cluster supports maintenance_config #12762

Conversation

ms-henglu
Copy link
Contributor

@ms-henglu ms-henglu commented Jul 28, 2021

rewrite #12305, embed maintenance resource to kubernetes_cluster

=== RUN   TestAccKubernetesCluster_updateMaintenanceConfig
=== PAUSE TestAccKubernetesCluster_updateMaintenanceConfig
=== CONT  TestAccKubernetesCluster_updateMaintenanceConfig
--- PASS: TestAccKubernetesCluster_updateMaintenanceConfig (913.75s)

=== RUN   TestAccKubernetesCluster_basicMaintenanceConfig
=== PAUSE TestAccKubernetesCluster_basicMaintenanceConfig
=== CONT  TestAccKubernetesCluster_basicMaintenanceConfig
--- PASS: TestAccKubernetesCluster_basicMaintenanceConfig (910.13s)

=== RUN   TestAccKubernetesCluster_completeMaintenanceConfig
=== PAUSE TestAccKubernetesCluster_completeMaintenanceConfig
=== CONT  TestAccKubernetesCluster_completeMaintenanceConfig
--- PASS: TestAccKubernetesCluster_completeMaintenanceConfig(916.23s)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THis is causing all tests to fail:

------- Stdout: -------
=== RUN   TestAccKubernetesCluster_privateClusterOnWithPrivateDNSZoneSubDomain
=== PAUSE TestAccKubernetesCluster_privateClusterOnWithPrivateDNSZoneSubDomain
=== CONT  TestAccKubernetesCluster_privateClusterOnWithPrivateDNSZoneSubDomain
    testcase.go:88: Step 1/1 error: Error running apply: exit status 1
        
        Error: retrieving Maintenance Configuration for Managed Kubernetes Cluster ("Cluster: (Managed Cluster Name \"acctestaks210730050729703273\" / Resource Group \"acctestRG-aks-210730050729703273\")"): containerservice.MaintenanceConfigurationsClient#Get: Failure responding to request: StatusCode=404 -- Original Error: autorest/azure: Service returned an error. Status=404 Code="NotFound" Message="Could not find the maintenance configuration: default in subscription: *******, resourceGroup: acctestRG-aks-210730050729703273, resourceName: acctestaks210730050729703273."
        
          with azurerm_kubernetes_cluster.test,
          on terraform_plugin_test.tf line 28, in resource "azurerm_kubernetes_cluster" "test":
          28: resource "azurerm_kubernetes_cluster" "test" {
        
--- FAIL: TestAccKubernetesCluster_privateClusterOnWithPrivateDNSZoneSubDomain (1021.31s)
FAIL

@ms-henglu ms-henglu force-pushed the ticket-1861323-aks-support-maintenance-config branch from 0a3fb3a to 3387a92 Compare August 2, 2021 03:29
@ms-henglu ms-henglu requested a review from katbyte August 4, 2021 01:25
@ms-henglu
Copy link
Contributor Author

@katbyte , Hi, I've updated the commit, could you please take another look? Thanks!

@ms-henglu
Copy link
Contributor Author

@katbyte , thanks! I've added a commit to rename the fields according to your suggestions.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ms-henglu - LGTM 🚀

@katbyte katbyte merged commit 86819b8 into hashicorp:master Aug 5, 2021
katbyte added a commit that referenced this pull request Aug 5, 2021
@github-actions
Copy link

github-actions bot commented Aug 6, 2021

This functionality has been released in v2.71.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 6, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants