Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New resource azurerm_api_management_tag #12535

Merged
merged 31 commits into from
Aug 5, 2021
Merged

New resource azurerm_api_management_tag #12535

merged 31 commits into from
Aug 5, 2021

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented Jul 9, 2021 •
edited
Loading

Fix #10833

--- PASS: TestAccApiManagementTag_basic (274.12s)
--- PASS: TestAccApiManagementTag_requiresImport (289.36s)
--- PASS: TestAccApiManagementTag_update (416.31s)

yupwei68 added 28 commits May 26, 2021 14:23
update
2cdcd9c
Merge branch 'master' of https://github.com/yupwei68/terraform-provid…
ba8f607 
…er-azurerm
Merge branch 'master' of https://github.com/terraform-providers/terra…
ad34b7b 
…form-provider-azurerm
Merge branch 'master' of https://github.com/terraform-providers/terra…
edf2cd8 
…form-provider-azurerm
revert
420097a
Merge branch 'master' of https://github.com/terraform-providers/terra…
e3294fc 
…form-provider-azurerm
Merge branch 'master' of https://github.com/terraform-providers/terra…
86da91a 
…form-provider-azurerm
Merge branch 'master' of https://github.com/terraform-providers/terra…
09b9f8e 
…form-provider-azurerm
Merge branch 'master' of https://github.com/terraform-providers/terra…
2f55300 
…form-provider-azurerm
Merge branch 'master' of https://github.com/terraform-providers/terra…
c03c58d 
…form-provider-azurerm
Merge branch 'master' of https://github.com/terraform-providers/terra…
57c031c 
…form-provider-azurerm
Merge branch 'master' of https://github.com/terraform-providers/terra…
a6d7062 
…form-provider-azurerm
Merge branch 'master' of https://github.com/terraform-providers/terra…
42b8b23 
…form-provider-azurerm
Merge branch 'master' of https://github.com/terraform-providers/terra…
ef31b67 
…form-provider-azurerm
Merge branch 'master' of https://github.com/terraform-providers/terra…
e054708 
…form-provider-azurerm
Merge branch 'master' of https://github.com/yupwei68/terraform-provid…
3f35b09 
…er-azurerm
Merge branch 'master' of https://github.com/terraform-providers/terra…
6dc973e 
…form-provider-azurerm
Merge branch 'master' of https://github.com/terraform-providers/terra…
3363bb5 
…form-provider-azurerm
Merge branch 'master' of https://github.com/terraform-providers/terra…
b9d7f9a 
…form-provider-azurerm
Merge branch 'master' of https://github.com/terraform-providers/terra…
014c3bd 
…form-provider-azurerm
Merge branch 'master' of https://github.com/terraform-providers/terra…
9223d60 
…form-provider-azurerm
Merge branch 'master' of https://github.com/terraform-providers/terra…
788fecb 
…form-provider-azurerm
Merge branch 'master' of https://github.com/terraform-providers/terra…
cf090fc 
…form-provider-azurerm
Merge branch 'master' of https://github.com/terraform-providers/terra…
33ae98d 
…form-provider-azurerm
Merge branch 'master' of https://github.com/terraform-providers/terra…
2a4e708 
…form-provider-azurerm
Merge branch 'master' of https://github.com/terraform-providers/terra…
5a48171 
…form-provider-azurerm
update
1686b95
update
d145003
manicminer
manicminer suggested changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yupwei68, thanks for the PR. I've made some small suggestions below, mostly around string/error formatting. If you can fix these up and the tests pass, this should be good to merge.

azurerm/internal/services/apimanagement/api_management_tag_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/apimanagement/api_management_tag_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/apimanagement/api_management_tag_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/apimanagement/api_management_tag_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/apimanagement/api_management_tag_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/apimanagement/api_management_tag_resource_test.go Outdated Show resolved Hide resolved
azurerm/internal/services/apimanagement/api_management_tag_resource_test.go Outdated Show resolved Hide resolved
azurerm/internal/services/apimanagement/api_management_tag_resource_test.go Outdated Show resolved Hide resolved
azurerm/internal/services/apimanagement/api_management_tag_resource_test.go Outdated Show resolved Hide resolved
azurerm/internal/services/apimanagement/api_management_tag_resource_test.go Outdated Show resolved Hide resolved
@manicminer manicminer added this to the v2.68.0 milestone Jul 14, 2021
@katbyte katbyte modified the milestones: v2.68.0, v2.69.0, v2.70.0 Jul 16, 2021
@katbyte katbyte modified the milestones: v2.70.0, v2.71.0 Jul 30, 2021
yupwei68 added 2 commits July 30, 2021 13:59
@yupwei68
Copy link
Contributor Author

@manicminer Thanks for comments. Please continue reviewing.

katbyte
katbyte approved these changes Aug 5, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yupwei68 - LGTM 🚀

@katbyte katbyte merged commit 1739b56 into hashicorp:master Aug 5, 2021
katbyte added a commit that referenced this pull request Aug 5, 2021
@katbyte
CHANGELOG.md for #12535
e9751bd
@github-actions
Copy link

github-actions bot commented Aug 6, 2021

This functionality has been released in v2.71.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 6, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manicminer manicminer manicminer requested changes

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation new-resource service/api-management size/XL
Projects
None yet
Milestone
v2.71.0
Development

Successfully merging this pull request may close these issues.

Support for API Management Service tag
3 participants
@yupwei68 @manicminer @katbyte