Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_logic_app_workflow - add supports for workflow_parameters #12314

Merged
merged 5 commits into from
Jul 30, 2021

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Jun 22, 2021

Add supports for the workflow_parameters (the paramter definition),
and also make the parameters (the paramter value) to support different
kinds of types (previously it only supports String).

Fixes: #7241, #11505

Add supports for the `workflow_parameters` (the paramter definition),
and also make the `parameters` (the paramter value) to support different
kinds of types (previously it only supports `String`).
Comment on lines 355 to 360
lifecycle {
ignore_changes = [
parameters["secstr"],
parameters["secobj"],
]
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come we are ignoring changes heres?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are secure types, means they will not return from API on read.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so in that case we should be pulling the existing values from the config through into the read function so the user does not have to do this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I've updated the code to read the security params from state, and ignore them in the import verification accordingly. Also I refined the test for the "Array", with some modification on the code.

Test Result

💤 TF_ACC=1 go test -timeout=3h -v ./azurerm/internal/services/logic -run='TestAccLogicAppWorkflow_parameters'
=== RUN   TestAccLogicAppWorkflow_parameters                                                             
=== PAUSE TestAccLogicAppWorkflow_parameters                                                             
=== CONT  TestAccLogicAppWorkflow_parameters                                                             
--- PASS: TestAccLogicAppWorkflow_parameters (92.06s)                  
PASS                                                                                                     
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/logic       92.080s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magodo - LGTM ❄️ - good to merge once the conflicts are resolves

@magodo
Copy link
Collaborator Author

magodo commented Jul 30, 2021

@katbyte Thanks for the reminder, merged with the master now.

@katbyte katbyte modified the milestones: v2.70.0, v2.71.0 Jul 30, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magodo - LGTM ⛰️

@katbyte katbyte merged commit f9687a6 into hashicorp:master Jul 30, 2021
katbyte added a commit that referenced this pull request Jul 30, 2021
@github-actions
Copy link

github-actions bot commented Aug 6, 2021

This functionality has been released in v2.71.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 6, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Logic App workflow should allow parameters to be any object (not just strings)
2 participants