-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_logic_app_workflow
- add supports for workflow_parameters
#12314
azurerm_logic_app_workflow
- add supports for workflow_parameters
#12314
Conversation
Add supports for the `workflow_parameters` (the paramter definition), and also make the `parameters` (the paramter value) to support different kinds of types (previously it only supports `String`).
lifecycle { | ||
ignore_changes = [ | ||
parameters["secstr"], | ||
parameters["secobj"], | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how come we are ignoring changes heres?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are secure types, means they will not return from API on read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so in that case we should be pulling the existing values from the config through into the read function so the user does not have to do this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. I've updated the code to read the security params from state, and ignore them in the import verification accordingly. Also I refined the test for the "Array", with some modification on the code.
Test Result
💤 TF_ACC=1 go test -timeout=3h -v ./azurerm/internal/services/logic -run='TestAccLogicAppWorkflow_parameters'
=== RUN TestAccLogicAppWorkflow_parameters
=== PAUSE TestAccLogicAppWorkflow_parameters
=== CONT TestAccLogicAppWorkflow_parameters
--- PASS: TestAccLogicAppWorkflow_parameters (92.06s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/logic 92.080s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @magodo - LGTM ❄️ - good to merge once the conflicts are resolves
@katbyte Thanks for the reminder, merged with the master now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @magodo - LGTM ⛰️
This functionality has been released in v2.71.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Add supports for the
workflow_parameters
(the paramter definition),and also make the
parameters
(the paramter value) to support differentkinds of types (previously it only supports
String
).Fixes: #7241, #11505