Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_account_network_rules and azurerm_storage_account - private_link_access supports more values #11957

Merged
merged 3 commits into from
May 26, 2021

Conversation

yupwei68
Copy link
Contributor

Fix #11779

--- PASS: TestAccStorageAccountNetworkRules_SynapseAccess (1595.74s)
--- PASS: TestAccStorageAccount_networkRulesSynapseAccess (1123.84s)

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title Fix validation of private_link_access in azurerm_storage_account_network_rules and azurerm_storage_account azurerm_storage_account_network_rules and azurerm_storage_account - private_link_access supports more values May 26, 2021
@mbfrahry mbfrahry merged commit aac8ca0 into hashicorp:master May 26, 2021
mbfrahry added a commit that referenced this pull request May 26, 2021
@mbfrahry mbfrahry added this to the v2.61.0 milestone May 26, 2021
@yupwei68 yupwei68 deleted the wyp-storage-privatelink branch May 27, 2021 07:03
@ghost
Copy link

ghost commented May 27, 2021

This has been released in version 2.61.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.61.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for private_link_access in azurerm_storage_account doesn't work as intended
2 participants