azurerm_storage_share: Fix ID for resource_manager_id

[favoretti]

@tombuildsstuff Wonder if we need a state migration here too?

Fixes #11624

[magodo]

@favoretti I suppose yes, we need to migrate the state as the ID has changed.

[favoretti]

@magodo as discussed with @tombuildsstuff offline just now, we should be fine without a state migration here. Please do call the ID change for the computed value of resource_manager_id in azurerm_storage_share resource in the CHANGELOG when merging.

Thanks!

[tombuildsstuff]

+1 yeah this shouldn't need a state migration since this is a computed field - but as mentioned above we do need to document that this is changing. The question here is why this changed in the API, was this incorrect in the first place - or is this a breaking change to the API?

[favoretti]

I might have just shot this one in the head by adding sdkv2 shim to storage, but if/when that one gets in, I'll rebase this.

[mbfrahry]

LGTM!

[ghost]

This has been released in version 2.61.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.61.0"
}
# ... other configuration ...

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.