Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_frontdoor_custom_https_configuration - add support for import #11642

Merged
merged 13 commits into from
May 12, 2021

Conversation

WodansSon
Copy link
Collaborator

Add support for azurerm_frontdoor_custom_https_configuration resource import.

(fixes #11623)

@WodansSon WodansSon added this to the v2.59.0 milestone May 10, 2021
@ghost ghost added the size/S label May 10, 2021
@ghost ghost added the documentation label May 10, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WodansSon - LGTM 👍

@ghost ghost added size/XL and removed size/S labels May 11, 2021
@WodansSon
Copy link
Collaborator Author

image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a couple comments LGTM

@@ -10,8 +10,6 @@ description: |-

Manages the Custom Https Configuration for an Azure Front Door Frontend Endpoint..

~> **NOTE:** Custom https configurations for a Front Door Frontend Endpoint can be defined both within [the `azurerm_frontdoor` resource](frontdoor.html) via the `custom_https_configuration` block and by using a separate resource, as described in the following sections.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we link to the new guide on this page?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@WodansSon WodansSon merged commit 2852c72 into master May 12, 2021
@WodansSon WodansSon deleted the b-frontdoor-custom-https branch May 12, 2021 00:24
WodansSon added a commit that referenced this pull request May 12, 2021
@ghost
Copy link

ghost commented May 14, 2021

This has been released in version 2.59.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.59.0"
}
# ... other configuration ...

favoretti pushed a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Front Door: Upgrade 2.57 -> 2.58 breaks on existing FD instances with inline HTTPS configuration
2 participants