-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_frontdoor_custom_https_configuration
- add support for import
#11642
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @WodansSon - LGTM 👍
azurerm/internal/services/frontdoor/frontdoor_custom_https_configuration_resource.go
Outdated
Show resolved
Hide resolved
…figuration_resource.go
…rm-providers/terraform-provider-azurerm into b-frontdoor-custom-https
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from a couple comments LGTM
website/docs/guides/2.58.0-frontdoor-upgrade-guide.html.markdown
Outdated
Show resolved
Hide resolved
@@ -10,8 +10,6 @@ description: |- | |||
|
|||
Manages the Custom Https Configuration for an Azure Front Door Frontend Endpoint.. | |||
|
|||
~> **NOTE:** Custom https configurations for a Front Door Frontend Endpoint can be defined both within [the `azurerm_frontdoor` resource](frontdoor.html) via the `custom_https_configuration` block and by using a separate resource, as described in the following sections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we link to the new guide on this page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
website/docs/guides/2.58.0-frontdoor-upgrade-guide.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/guides/2.58.0-frontdoor-upgrade-guide.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/guides/2.58.0-frontdoor-upgrade-guide.html.markdown
Outdated
Show resolved
Hide resolved
This has been released in version 2.59.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.59.0"
}
# ... other configuration ... |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Add support for
azurerm_frontdoor_custom_https_configuration
resource import.(fixes #11623)