Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for conflict_resolution_policy in azurerm_cosmosdb_sql_container #11517

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented Apr 29, 2021

Fix #11516

changes on gremlin graph:
conflict_resolution_policy changes from Required to Optional and Computed. All tests have passed.

sql container:
=== RUN TestAccCosmosDbSqlContainer_basic
=== PAUSE TestAccCosmosDbSqlContainer_basic
=== CONT TestAccCosmosDbSqlContainer_basic
--- PASS: TestAccCosmosDbSqlContainer_basic (1243.44s)
=== RUN TestAccCosmosDbSqlContainer_basic_serverless
=== PAUSE TestAccCosmosDbSqlContainer_basic_serverless
=== CONT TestAccCosmosDbSqlContainer_basic_serverless
--- PASS: TestAccCosmosDbSqlContainer_basic_serverless (1285.10s)
=== RUN TestAccCosmosDbSqlContainer_complete
=== PAUSE TestAccCosmosDbSqlContainer_complete
=== CONT TestAccCosmosDbSqlContainer_complete
--- PASS: TestAccCosmosDbSqlContainer_complete (1316.33s)
=== RUN TestAccCosmosDbSqlContainer_update
=== PAUSE TestAccCosmosDbSqlContainer_update
=== CONT TestAccCosmosDbSqlContainer_update
--- PASS: TestAccCosmosDbSqlContainer_update (1589.50s)
=== RUN TestAccCosmosDbSqlContainer_autoscale
=== PAUSE TestAccCosmosDbSqlContainer_autoscale
=== CONT TestAccCosmosDbSqlContainer_autoscale
--- PASS: TestAccCosmosDbSqlContainer_autoscale (1915.56s)
=== RUN TestAccCosmosDbSqlContainer_indexing_policy
=== PAUSE TestAccCosmosDbSqlContainer_indexing_policy
=== CONT TestAccCosmosDbSqlContainer_indexing_policy
--- PASS: TestAccCosmosDbSqlContainer_indexing_policy (1883.89s)
=== RUN TestAccCosmosDbSqlContainer_partition_key_version
=== PAUSE TestAccCosmosDbSqlContainer_partition_key_version
=== CONT TestAccCosmosDbSqlContainer_partition_key_version
--- PASS: TestAccCosmosDbSqlContainer_partition_key_version (1335.42s)
=== RUN TestAccCosmosDbSqlContainer_customConflictResolutionPolicy
=== PAUSE TestAccCosmosDbSqlContainer_customConflictResolutionPolicy
=== CONT TestAccCosmosDbSqlContainer_customConflictResolutionPolicy
--- PASS: TestAccCosmosDbSqlContainer_customConflictResolutionPolicy (1364.63s)

gremlin graph:
=== RUN TestAccCosmosDbGremlinGraph_basic
=== PAUSE TestAccCosmosDbGremlinGraph_basic
=== CONT TestAccCosmosDbGremlinGraph_basic
--- PASS: TestAccCosmosDbGremlinGraph_basic (1312.91s)
=== RUN TestAccCosmosDbGremlinGraph_requiresImport
=== PAUSE TestAccCosmosDbGremlinGraph_requiresImport
=== CONT TestAccCosmosDbGremlinGraph_requiresImport
--- PASS: TestAccCosmosDbGremlinGraph_requiresImport (1407.86s)
=== RUN TestAccCosmosDbGremlinGraph_customConflictResolutionPolicy
=== PAUSE TestAccCosmosDbGremlinGraph_customConflictResolutionPolicy
=== CONT TestAccCosmosDbGremlinGraph_customConflictResolutionPolicy
--- PASS: TestAccCosmosDbGremlinGraph_customConflictResolutionPolicy (1325.06s)
=== RUN TestAccCosmosDbGremlinGraph_indexPolicy
=== PAUSE TestAccCosmosDbGremlinGraph_indexPolicy
=== CONT TestAccCosmosDbGremlinGraph_indexPolicy
--- PASS: TestAccCosmosDbGremlinGraph_indexPolicy (1264.18s)
=== RUN TestAccCosmosDbGremlinGraph_update
=== PAUSE TestAccCosmosDbGremlinGraph_update
=== CONT TestAccCosmosDbGremlinGraph_update
--- PASS: TestAccCosmosDbGremlinGraph_update (1738.12s)
=== RUN TestAccCosmosDbGremlinGraph_autoscale
=== PAUSE TestAccCosmosDbGremlinGraph_autoscale
=== CONT TestAccCosmosDbGremlinGraph_autoscale
--- PASS: TestAccCosmosDbGremlinGraph_autoscale (1985.56s)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yupwei68 - LGTM 👍

@katbyte katbyte merged commit dccf656 into hashicorp:master Apr 29, 2021
katbyte added a commit that referenced this pull request Apr 29, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

@yupwei68 yupwei68 deleted the wyp-cosmos-sql-container branch May 6, 2021 02:17
@github-actions
Copy link

github-actions bot commented Jun 5, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for conflict_resolution_policy in azurerm_cosmosdb_sql_container
2 participants