Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for access_key_metadata_writes_enabled, mongo_server_version and network_acl_bypass in azurerm_cosmosdb_account #11486

Merged
merged 5 commits into from
May 4, 2021

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented Apr 27, 2021

Fix #11487

@yupwei68 yupwei68 changed the title Support for key_based_meta_write_access_enabled, cassandra_connector_enabled, mongo_server_version and network_acl_bypass in azurerm_cosmosdb_account Support for key_based_meta_write_access_enabled, mongo_server_version and network_acl_bypass in azurerm_cosmosdb_account Apr 27, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yupwei68 - have some comment about schema and if we can remove some of the breaking changes in this release

@yupwei68 yupwei68 changed the title Support for key_based_meta_write_access_enabled, mongo_server_version and network_acl_bypass in azurerm_cosmosdb_account Support for access_key_metadata_writes_enabled, mongo_server_version and network_acl_bypass in azurerm_cosmosdb_account Apr 28, 2021
@yupwei68
Copy link
Contributor Author

Hi kt, tests have passed. Please continue reviewing.
image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yupwei68 - LGTM 👍

@katbyte katbyte merged commit 4dfd321 into hashicorp:master May 4, 2021
katbyte added a commit that referenced this pull request May 4, 2021
@yupwei68 yupwei68 deleted the wyp-cosmos-acc3 branch May 6, 2021 02:17
@ghost
Copy link

ghost commented May 7, 2021

This has been released in version 2.58.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.58.0"
}
# ... other configuration ...

favoretti pushed a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
…on` and `network_acl_bypass` in `azurerm_cosmosdb_account` (hashicorp#11486)

Fix hashicorp#11487
favoretti pushed a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
@github-actions
Copy link

github-actions bot commented Jun 7, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants