r/azurerm_application_gateway: add firewall_policy_id config to path rules

[patst]

Fixes #9040 .

Enables the configuration of firewall_policy_id on path rules:

...
  path_rule {
        name                       = local.path_rule_name
        backend_address_pool_name  = local.backend_address_pool_name
        backend_http_settings_name = local.http_setting_name
        firewall_policy_id         = azurerm_web_application_firewall_policy.testfwp_path_rule.id
        paths = [
          "/test",
        ]
      }
...

The new Test passed:

make testacc TEST='./azurerm/internal/services/network/application_gateway_resource_test.go' TESTARGS='-run=TestAccApplicationGateway_customPathRuleFirewallPolicy' TESTTIMEOUT='120m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/network/application_gateway_resource_test.go -v -run=TestAccApplicationGateway_customPathRuleFirewallPolicy -timeout 120m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
2021/04/07 19:18:45 [DEBUG] not using binary driver name, it's no longer needed
2021/04/07 19:18:46 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccApplicationGateway_customPathRuleFirewallPolicy
=== PAUSE TestAccApplicationGateway_customPathRuleFirewallPolicy
=== CONT  TestAccApplicationGateway_customPathRuleFirewallPolicy
--- PASS: TestAccApplicationGateway_customPathRuleFirewallPolicy (1465.99s)
PASS
ok      command-line-arguments  1467.732s

[tombuildsstuff]

hey @patst

Thanks for this PR.

I've taken a look through and left a couple of comments inline but on the whole this looks pretty good - if we can fix those up then this should be good to merge 👍

Thanks!

[patst]

@tombuildsstuff thanks for the feedback, I applied your suggestions and generated the custom validator!

[tombuildsstuff]

LGTM - thanks for pushing those changes @patst

[katbyte]

@patst - while running the tests for this i got a failure:

------- Stdout: -------
=== RUN   TestAccApplicationGateway_customPathRuleFirewallPolicy
=== PAUSE TestAccApplicationGateway_customPathRuleFirewallPolicy
=== CONT  TestAccApplicationGateway_customPathRuleFirewallPolicy
    testing.go:620: Step 1/2 error: Error running apply: 
        Error: ID was missing the `firewallPolicies` element
        
          on config010598691/terraform_plugin_test.tf line 90, in resource "azurerm_application_gateway" "test":
          90: resource "azurerm_application_gateway" "test" {

if you can fix this up we can get this merged

[patst]

@katbyte sorry for that. The validator crashed it.

I renamed it and fixed the test:

make testacc TEST='./azurerm/internal/services/network/application_gateway_resource_test.go' TESTARGS='-run=TestAccApplicationGateway_customPathRuleFirewallPolicy' TESTTIMEOUT='120m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/network/application_gateway_resource_test.go -v -run=TestAccApplicationGateway_customPathRuleFirewallPolicy -timeout 120m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
2021/04/09 09:38:51 [DEBUG] not using binary driver name, it's no longer needed
2021/04/09 09:38:51 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccApplicationGateway_customPathRuleFirewallPolicy
=== PAUSE TestAccApplicationGateway_customPathRuleFirewallPolicy
=== CONT  TestAccApplicationGateway_customPathRuleFirewallPolicy
--- PASS: TestAccApplicationGateway_customPathRuleFirewallPolicy (1560.17s)
PASS
ok      command-line-arguments  1561.850s

[tombuildsstuff]

LGTM 👍

[tombuildsstuff]

Tests look good 👍

[ghost]

This has been released in version 2.56.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.56.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!