Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add has_root_access to netapp vol export rules #11105

Merged
merged 7 commits into from
Apr 8, 2021
Merged

feat: add has_root_access to netapp vol export rules #11105

merged 7 commits into from
Apr 8, 2021

Conversation

BrendanThompson
Copy link
Contributor

This adds the ability to set has_root_access on export_policies.

@ghost ghost added the size/XS label Mar 25, 2021
@ghost ghost added the documentation label Mar 25, 2021
@BrendanThompson
Copy link
Contributor Author

@katbyte @tombuildsstuff – any chance that I could get a review here? Keen to get this merged in ASAP 😃.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr @BrendanThompson - aside from one comment about the schema this looks good. Could we change has_root_access to root_access_enabled to be consistent with the rest of the provider?

@katbyte katbyte added this to the v2.54.0 milestone Mar 30, 2021
@BrendanThompson
Copy link
Contributor Author

@katbyte I have updated that as requested. Thanks 😊

@ghost ghost removed the waiting-response label Mar 30, 2021
@BrendanThompson
Copy link
Contributor Author

@katbyte – sorry I forgot to add this in everywhere -facepalm- I have pushed that change up now.

@ghost ghost added size/S and removed size/XS labels Apr 1, 2021
@katbyte katbyte modified the milestones: v2.54.0, v2.55.0 Apr 2, 2021
@BrendanThompson
Copy link
Contributor Author

@katbyte Will this change actually be released in this Friday's release?

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @BrendanThompson

Thanks for pushing those changes, I've left one comment around the documentation inline but this should otherwise be good to go 👍

Thanks!

@BrendanThompson
Copy link
Contributor Author

Hey @tombuildsstuff , thanks for that. I've updated as per the suggestion.

@ghost ghost removed the waiting-response label Apr 8, 2021
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for pushing that change @BrendanThompson

@tombuildsstuff tombuildsstuff dismissed katbyte’s stale review April 8, 2021 12:06

dismissing since changes have been pushed

@tombuildsstuff tombuildsstuff merged commit e647d7d into hashicorp:master Apr 8, 2021
tombuildsstuff added a commit that referenced this pull request Apr 8, 2021
@ghost
Copy link

ghost commented Apr 9, 2021

This has been released in version 2.55.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.55.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 8, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants