-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add has_root_access to netapp vol export rules #11105
feat: add has_root_access to netapp vol export rules #11105
Conversation
@katbyte @tombuildsstuff – any chance that I could get a review here? Keen to get this merged in ASAP 😃. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pr @BrendanThompson - aside from one comment about the schema this looks good. Could we change has_root_access
to root_access_enabled
to be consistent with the rest of the provider?
Co-authored-by: kt <[email protected]>
@katbyte I have updated that as requested. Thanks 😊 |
@katbyte – sorry I forgot to add this in everywhere -facepalm- I have pushed that change up now. |
@katbyte Will this change actually be released in this Friday's release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @BrendanThompson
Thanks for pushing those changes, I've left one comment around the documentation inline but this should otherwise be good to go 👍
Thanks!
Co-authored-by: Tom Harvey <[email protected]>
Hey @tombuildsstuff , thanks for that. I've updated as per the suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for pushing that change @BrendanThompson
dismissing since changes have been pushed
This has been released in version 2.55.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.55.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This adds the ability to set
has_root_access
onexport_policies
.