Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_communication_service #11066

Merged
merged 6 commits into from
Apr 5, 2021

Conversation

neil-yechenwei
Copy link
Contributor

Currently, there is no way to create Azure Communication Service. So I have to submit this PR to implement it.

The overview of Communication Service:
https://docs.microsoft.com/en-us/azure/communication-services/overview

API Doc:
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/communication/resource-manager/Microsoft.Communication/stable/2020-08-20/CommunicationService.json

--- PASS: TestAccCommunicationService_basic (283.97s)
--- PASS: TestAccCommunicationService_complete (291.39s)
--- PASS: TestAccCommunicationService_requiresImport (306.33s)
--- PASS: TestAccCommunicationService_update (390.25s)

@neil-yechenwei neil-yechenwei changed the title New Resource: azurerm_communication_service [WIP] New Resource: azurerm_communication_service Mar 24, 2021
@neil-yechenwei neil-yechenwei changed the title [WIP] New Resource: azurerm_communication_service New Resource: azurerm_communication_service Mar 25, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei - LGTM 👍

@katbyte katbyte added this to the v2.55.0 milestone Apr 5, 2021
@katbyte katbyte merged commit 1be7b09 into hashicorp:master Apr 5, 2021
katbyte added a commit that referenced this pull request Apr 5, 2021
@ghost
Copy link

ghost commented Apr 9, 2021

This has been released in version 2.55.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.55.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 5, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants