Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Service / App Service Slot / Function Apps - support for HTTPS Only #1080

Merged
merged 5 commits into from
Apr 6, 2018

Conversation

tombuildsstuff
Copy link
Contributor

Adds support for https_only to App Service, App Service Slot, Function App resources and the App Service Data Source

Fixes #756

@tombuildsstuff
Copy link
Contributor Author

@JunyiYi apologies, I've only just seen that you've been assigned to this issue after I'd opened this PR 🤦‍♂️

@tombuildsstuff
Copy link
Contributor Author

App Service tests pass:

$ acctests azurerm TestAccAzureRMAppService_httpsOnly
=== RUN   TestAccAzureRMAppService_httpsOnly
--- PASS: TestAccAzureRMAppService_httpsOnly (113.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	113.795s

App Service Slot tests pass:

$ acctests azurerm TestAccAzureRMAppServiceSlot_httpsOnly
=== RUN   TestAccAzureRMAppServiceSlot_httpsOnly
--- PASS: TestAccAzureRMAppServiceSlot_httpsOnly (111.72s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	111.758s

Function App tests pass:

$ acctests azurerm TestAccAzureRMFunctionApp_httpsOnly
=== RUN   TestAccAzureRMFunctionApp_httpsOnly
--- PASS: TestAccAzureRMFunctionApp_httpsOnly (104.63s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	104.683s

@tombuildsstuff tombuildsstuff added this to the 1.3.3 milestone Apr 5, 2018
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff tombuildsstuff merged commit 97ddd5b into master Apr 6, 2018
@tombuildsstuff tombuildsstuff deleted the app-service-https-only branch April 6, 2018 16:19
tombuildsstuff added a commit that referenced this pull request Apr 6, 2018
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants