Fixes bug #10773

[paulomarquesc]

• Fixing null check for issue related to executing plan in state generated by previous azurerm version (e.g. 2.48.0) where data_protection_replication was not part of the schema yet.
• Improvement on null and endpoint checks on flattenNetAppVolumeDataProtectionReplication function.

Note: fixes #10773

[katbyte]

LGTM 👍

[tombuildsstuff]

hey @paulomarquesc

Thanks for this PR.

Taking a look through on the whole this looks pretty good - however we'll want to remove the if statements around the Set calls to ensure we track when these fields are removed/emptied out - but if we can fix those up this should otherwise be good to go 👍

Thanks!

[paulomarquesc]

Hi @tombuildsstuff, I'm not sure if you're asking to remove the whole if statement since I see only part of the line highlighted, but I believe so because that would be the only way this would work since the API don't even return the props.DataProtection if nothing is set and not testing for it first would case the issue pointed in the opened bug.

[paulomarquesc]

@tombuildsstuff, changes are now applied, they make sense, thanks for spotting it.

[tombuildsstuff]

LGTM 👍

[ghost]

This has been released in version 2.50.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.50.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!