Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not set source property when update Spring cloud deployment #10729

Merged
merged 4 commits into from
Mar 1, 2021

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Feb 25, 2021

split createUpdate func.

fix bug:
terraform does not support upload jar, users would do this through other tools, such as azure.cli.
when create in terraform, we would set the source to a default value, and for update fucntion, we should not change the source property

image

@ghost ghost added the size/M label Feb 25, 2021
@njuCZ njuCZ changed the title Spring cloud deployment fix not set source property when update Spring cloud deployment Feb 25, 2021
@njuCZ njuCZ force-pushed the spring_cloud_deployment_fix branch from 1aa219c to 1062cb2 Compare February 25, 2021 06:32
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor

tombuildsstuff commented Mar 1, 2021

Tests pass:

Screenshot 2021-03-01 at 08 47 23

@tombuildsstuff tombuildsstuff merged commit ae0bd0f into hashicorp:master Mar 1, 2021
tombuildsstuff added a commit that referenced this pull request Mar 1, 2021
@ghost
Copy link

ghost commented Mar 5, 2021

This has been released in version 2.50.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.50.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 31, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants