Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new data source "azurerm_spring_cloud_app" #10678

Merged
merged 3 commits into from
Feb 22, 2021

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Feb 22, 2021

data source for spring cloud app

image

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @njuCZ

Thanks for this PR - I've taken a look through and left some comments inline, but on the whole this looks pretty good - if we can fix those up then this should otherwise be good to go 👍

Thanks!

website/docs/d/spring_cloud_app.html.markdown Outdated Show resolved Hide resolved
website/docs/d/spring_cloud_app.html.markdown Outdated Show resolved Hide resolved
website/docs/d/spring_cloud_app.html.markdown Outdated Show resolved Hide resolved
website/docs/d/spring_cloud_app.html.markdown Outdated Show resolved Hide resolved
website/docs/d/spring_cloud_app.html.markdown Outdated Show resolved Hide resolved
website/docs/d/spring_cloud_app.html.markdown Outdated Show resolved Hide resolved
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2021-02-22 at 09 43 22

@tombuildsstuff tombuildsstuff merged commit 692c90f into hashicorp:master Feb 22, 2021
tombuildsstuff added a commit that referenced this pull request Feb 22, 2021
@njuCZ
Copy link
Contributor Author

njuCZ commented Feb 22, 2021

@tombuildsstuff thanks for your quick review!

@ghost
Copy link

ghost commented Feb 26, 2021

This has been released in version 2.49.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.49.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 24, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants