Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resource: azurerm_sentinel_data_connector_threat_intelligence #10670

Merged

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Feb 20, 2021

new resource: azurerm_sentinel_data_connector_threat_intelligence

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @magodo

Thanks for this PR - taking a look through this is looking good, if we can fix up the (mostly minor) comments then this should otherwise be good to go 👍

Thanks!

@magodo magodo force-pushed the sentinel_dataconnector_threat_intelligence branch from 15091b1 to 2ec9566 Compare February 23, 2021 01:31
@magodo
Copy link
Collaborator Author

magodo commented Feb 23, 2021

@tombuildsstuff

Thank you for the comments! I've rebased the original commit onto your last merged base commit, and also have resolved the review comments. Please take another review.

@katbyte katbyte modified the milestones: v2.49.0, v2.50.0 Feb 25, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte merged commit 5f2f799 into hashicorp:master Mar 1, 2021
katbyte added a commit that referenced this pull request Mar 1, 2021
@ghost
Copy link

ghost commented Mar 5, 2021

This has been released in version 2.50.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.50.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 31, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants