Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_mssql_virtual_machine: support auto_backup #10460

Merged
merged 5 commits into from
Feb 11, 2021

Conversation

manicminer
Copy link
Contributor

Replaces #10107

Support configuring auto backup for azurerm_mssql_virtual_machine

  • Enabling/disabling is determined by presence of auto_backup block
  • WaitForState func is needed as auto backup settings take awhile to take effect, whether adding/removing or updating

@manicminer manicminer added enhancement service/mssql Microsoft SQL Server labels Feb 4, 2021
@manicminer manicminer added this to the v2.47.0 milestone Feb 4, 2021
@manicminer manicminer force-pushed the f/mssql-virtual-machine-auto-backup branch 2 times, most recently from cad0361 to 66fe84f Compare February 4, 2021 03:01
@manicminer manicminer force-pushed the f/mssql-virtual-machine-auto-backup branch from 66fe84f to 9b911ca Compare February 4, 2021 03:32
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a couple questions about schema names but otherwise is looking good

@manicminer
Copy link
Contributor Author

@katbyte I've dropped the toggle attribute for automatic/manual backup scheduling, and used the presence of the manual_schedule block instead, which has simplified the custom diff function. Also, due to a service error, auto_backup cannot be removed without causing the resource to fail.

Still pending test results due to the memory issue on the CI server, but it's passing locally for me with these test configs.

@manicminer manicminer requested a review from katbyte February 5, 2021 02:44
@manicminer
Copy link
Contributor Author

manicminer commented Feb 5, 2021

Test results

Screenshot 2021-02-05 at 15 16 32

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @manicminer - LGTM now!

@jackofallops jackofallops merged commit 590df3a into master Feb 11, 2021
@jackofallops jackofallops deleted the f/mssql-virtual-machine-auto-backup branch February 11, 2021 08:04
jackofallops added a commit that referenced this pull request Feb 11, 2021
@ghost
Copy link

ghost commented Feb 11, 2021

This has been released in version 2.47.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.47.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 13, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants