-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_mssql_virtual_machine: support auto_backup #10460
Conversation
cad0361
to
66fe84f
Compare
66fe84f
to
9b911ca
Compare
…or changes in configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a couple questions about schema names but otherwise is looking good
azurerm/internal/services/mssql/mssql_virtual_machine_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/mssql/mssql_virtual_machine_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/mssql/mssql_virtual_machine_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/mssql/mssql_virtual_machine_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/mssql/mssql_virtual_machine_resource.go
Outdated
Show resolved
Hide resolved
@katbyte I've dropped the toggle attribute for automatic/manual backup scheduling, and used the presence of the Still pending test results due to the memory issue on the CI server, but it's passing locally for me with these test configs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @manicminer - LGTM now!
This has been released in version 2.47.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.47.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Replaces #10107
Support configuring auto backup for azurerm_mssql_virtual_machine
auto_backup
block