Prevent infinite loop if an API error is returned when waiting for an async operation to complete

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
• The resources and data sources in this provider are generated from the CloudFormation schema, so they can only support the actions that the underlying schema supports. For this reason submitted bugs should be limited to defects in the generation and runtime code of the provider. Customizing behavior of the resource, or noting a gap in behavior are not valid bugs and should be submitted as enhancements to AWS via the CloudFormation Open Coverage Roadmap.

Closes #486.

Testing with a resource that exercises the waiter:

% TF_LOG=ERROR make testacc PKG_NAME=internal/aws/ec2 TESTARGS='-run=TestAccAWSEC2VPC_CidrBlock'
TF_ACC=1 go test ./internal/aws/ec2 -v -count 1 -parallel 20 -run=TestAccAWSEC2VPC_CidrBlock -timeout 180m
=== RUN   TestAccAWSEC2VPC_CidrBlock
=== PAUSE TestAccAWSEC2VPC_CidrBlock
=== CONT  TestAccAWSEC2VPC_CidrBlock
--- PASS: TestAccAWSEC2VPC_CidrBlock (36.87s)
PASS
ok  	github.com/hashicorp/terraform-provider-awscc/internal/aws/ec2	37.826s

[gdavison]

Looks good! 🚀