Fix Provider returned invalid result object after apply errors

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
• The resources and data sources in this provider are generated from the CloudFormation schema, so they can only support the actions that the underlying schema supports. For this reason submitted bugs should be limited to defects in the generation and runtime code of the provider. Customizing behavior of the resource, or noting a gap in behavior are not valid bugs and should be submitted as enhancements to AWS via the CloudFormation Open Coverage Roadmap.

Fixes Provider returned invalid result object after apply errors on Create for numerous resources.
This error was caused by unknown values being present in state after the resource was successfully created. In particular, unknown values in SetNestedAttributes were not being populated from the resource's current (post-creation) state.

Closes #960.
Closes #1280.
Closes #1279.
Closes #1039.
Closes #811.
Closes #799.
Closes #719.
Closes #545.

[bflad]

Does the API 100% guarantee that all configured values are exactly preserved? If not, Terraform can/will start throwing data consistency errors if any planned value changes during apply.

[ewbankkit]

Not it doesn't, and I discovered that pretty quickly when testing with IAM policy documents.
When I get time to get back to this I'm going to revert the "simplification" and look at the underlying unknown value copying problem.

[ewbankkit]

The problem with unknown values not being populated in e.g. #960 is caused by the logic that copies current resource state to Terraform state being unable to match (and then overwrite) schema.SetNestedAttribute elements in the resource state (which contain no unknown values) with those in the Terraform state (which do contain unknown values).
It boils down to Data.TerraformValueAtTerraformPath calling tftypes.Value.ApplyTerraform5AttributePathStep calling tftypes.Value.deepEqual for a path step of type ElementKeyValue (i.e. a set element).