Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix lambda_arn casing in pre_token_generation_config #36426

Merged

Conversation

AndresMorelos
Copy link
Contributor

@AndresMorelos AndresMorelos commented Mar 17, 2024

Description

This PR corrects the casing of the lambda_arn variable in the documentation for the pre-token generation configuration. Previously, the casing may have been incorrect, leading to potential confusion or errors. The correction ensures that users referencing the documentation will use the correct casing for lambda_arn in their own configurations.

Relations

Closes #36420.
Relates #35236.

References

CleanShot 2024-03-16 at 20 26 08

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2
Not needed since is documentation
...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. labels Mar 17, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 17, 2024
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Mar 18, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@AndresMorelos Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit a5c0a66 into hashicorp:main Mar 18, 2024
55 checks passed
@github-actions github-actions bot added this to the v5.42.0 milestone Mar 18, 2024
@AndresMorelos AndresMorelos deleted the fix-pre_token_configuration-docs branch March 18, 2024 14:35
Copy link

This functionality has been released in v5.42.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: aws_cognito_user_pool pre_token_configuration_type Camel Case Arguments
2 participants