Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Grafana API key as sensitive. #34105

Merged
merged 15 commits into from
Nov 16, 2023

Commits on Oct 25, 2023

  1. Configuration menu
    Copy the full SHA
    c2ecfbe View commit details
    Browse the repository at this point in the history
  2. changelog entry

    jrouly committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    99a1eda View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Update 34105.txt

    ewbankkit authored Nov 15, 2023
    Configuration menu
    Copy the full SHA
    861fbb3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1f49d8a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    118e152 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5b46570 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7698db5 View commit details
    Browse the repository at this point in the history
  6. Acceptance test output:

    % make testacc TESTARGS='-run=TestAccGrafana_serial/Workspace/configuration' PKG=grafana
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/grafana/... -v -count 1 -parallel 20  -run=TestAccGrafana_serial/Workspace/configuration -timeout 360m
    === RUN   TestAccGrafana_serial
    === PAUSE TestAccGrafana_serial
    === CONT  TestAccGrafana_serial
    === RUN   TestAccGrafana_serial/Workspace
    === RUN   TestAccGrafana_serial/Workspace/configuration
    --- PASS: TestAccGrafana_serial (621.17s)
        --- PASS: TestAccGrafana_serial/Workspace (621.17s)
            --- PASS: TestAccGrafana_serial/Workspace/configuration (621.17s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/grafana	631.729s
    ewbankkit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    e44a213 View commit details
    Browse the repository at this point in the history
  7. Add CHANGELOG entry.

    ewbankkit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    d5dbad1 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    133951b View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Acceptance test output:

    % make testacc TESTARGS='-run=TestAccGrafana_serial/Workspace/' PKG=grafana
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/grafana/... -v -count 1 -parallel 20  -run=TestAccGrafana_serial/Workspace/ -timeout 360m
    === RUN   TestAccGrafana_serial
    === PAUSE TestAccGrafana_serial
    === CONT  TestAccGrafana_serial
    === RUN   TestAccGrafana_serial/Workspace
    === RUN   TestAccGrafana_serial/Workspace/tags
    === RUN   TestAccGrafana_serial/Workspace/saml
    === RUN   TestAccGrafana_serial/Workspace/organization
        acctest.go:1009: this AWS account must be the management account of an AWS Organization
    === RUN   TestAccGrafana_serial/Workspace/dataSources
    === RUN   TestAccGrafana_serial/Workspace/permissionType
    === RUN   TestAccGrafana_serial/Workspace/notificationDestinations
    === RUN   TestAccGrafana_serial/Workspace/version
    === RUN   TestAccGrafana_serial/Workspace/sso
        acctest.go:1051: skipping tests; no SSO Instances found.
    === RUN   TestAccGrafana_serial/Workspace/disappears
    === RUN   TestAccGrafana_serial/Workspace/vpc
        workspace_test.go:114: Step 1/4 error: Error running apply: exit status 1
    
            Error: creating EC2 VPC: operation error EC2: CreateVpc, https response error StatusCode: 400, RequestID: ebca4a7c-ac66-436c-b2aa-1975e1b66e08, api error VpcLimitExceeded: The maximum number of VPCs has been reached.
    
              with aws_vpc.test,
              on terraform_plugin_test.tf line 30, in resource "aws_vpc" "test":
              30: resource "aws_vpc" "test" {
    
    === RUN   TestAccGrafana_serial/Workspace/configuration
    === RUN   TestAccGrafana_serial/Workspace/networkAccess
    --- FAIL: TestAccGrafana_serial (4103.41s)
        --- FAIL: TestAccGrafana_serial/Workspace (4103.41s)
            --- PASS: TestAccGrafana_serial/Workspace/tags (358.91s)
            --- PASS: TestAccGrafana_serial/Workspace/saml (320.42s)
            --- SKIP: TestAccGrafana_serial/Workspace/organization (0.70s)
            --- PASS: TestAccGrafana_serial/Workspace/dataSources (321.41s)
            --- PASS: TestAccGrafana_serial/Workspace/permissionType (348.85s)
            --- PASS: TestAccGrafana_serial/Workspace/notificationDestinations (349.90s)
            --- PASS: TestAccGrafana_serial/Workspace/version (601.81s)
            --- SKIP: TestAccGrafana_serial/Workspace/sso (0.45s)
            --- PASS: TestAccGrafana_serial/Workspace/disappears (318.63s)
            --- FAIL: TestAccGrafana_serial/Workspace/vpc (11.98s)
            --- PASS: TestAccGrafana_serial/Workspace/configuration (666.38s)
            --- PASS: TestAccGrafana_serial/Workspace/networkAccess (803.97s)
    FAIL
    FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/grafana	4109.237s
    FAIL
    make: *** [testacc] Error 1
    ewbankkit committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    e45df1d View commit details
    Browse the repository at this point in the history
  2. Revert "Add CHANGELOG entry."

    This reverts commit d5dbad1.
    ewbankkit committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    d5943cf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f807805 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    60be560 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    be2a8be View commit details
    Browse the repository at this point in the history