Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Skip listing tags on aws_vpclattice_service_network data source when shared via RAM #32939

Merged
merged 7 commits into from
Aug 10, 2023

Commits on Aug 9, 2023

  1. Configuration menu
    Copy the full SHA
    546a922 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Tweak CHANGELOG entry.

    ewbankkit committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    ae8b284 View commit details
    Browse the repository at this point in the history
  2. d/aws_vpclattice_service_network: Tidy up.

    Acceptance test output:
    
    % make testacc TESTARGS='-run=TestAccVPCLatticeServiceNetworkDataSource_' PKG=vpclattice ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/vpclattice/... -v -count 1 -parallel 2  -run=TestAccVPCLatticeServiceNetworkDataSource_ -timeout 180m
    === RUN   TestAccVPCLatticeServiceNetworkDataSource_basic
    === PAUSE TestAccVPCLatticeServiceNetworkDataSource_basic
    === CONT  TestAccVPCLatticeServiceNetworkDataSource_basic
    --- PASS: TestAccVPCLatticeServiceNetworkDataSource_basic (23.41s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice	28.927s
    ewbankkit committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    0e49849 View commit details
    Browse the repository at this point in the history
  3. d/aws_vpclattice_service_network: Add 'TestAccVPCLatticeServiceNetwor…

    …kDataSource_shared'.
    
    Acceptance test output:
    
    % make testacc TESTARGS='-run=TestAccVPCLatticeServiceNetworkDataSource_shared' PKG=vpclattice ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/vpclattice/... -v -count 1 -parallel 2  -run=TestAccVPCLatticeServiceNetworkDataSource_shared -timeout 180m
    === RUN   TestAccVPCLatticeServiceNetworkDataSource_shared
    === PAUSE TestAccVPCLatticeServiceNetworkDataSource_shared
    === CONT  TestAccVPCLatticeServiceNetworkDataSource_shared
    --- PASS: TestAccVPCLatticeServiceNetworkDataSource_shared (40.59s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice	45.992s
    ewbankkit committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    33e897a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ce752d6 View commit details
    Browse the repository at this point in the history
  5. d/aws_vpclattice_service: Tidy up acceptance tests.

    Acceptance test output:
    
    % make testacc TESTARGS='-run=TestAccVPCLatticeServiceDataSource_' PKG=vpclattice ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/vpclattice/... -v -count 1 -parallel 2  -run=TestAccVPCLatticeServiceDataSource_ -timeout 180m
    === RUN   TestAccVPCLatticeServiceDataSource_basic
    === PAUSE TestAccVPCLatticeServiceDataSource_basic
    === RUN   TestAccVPCLatticeServiceDataSource_byName
    === PAUSE TestAccVPCLatticeServiceDataSource_byName
    === CONT  TestAccVPCLatticeServiceDataSource_basic
    === CONT  TestAccVPCLatticeServiceDataSource_byName
    --- PASS: TestAccVPCLatticeServiceDataSource_basic (28.19s)
    --- PASS: TestAccVPCLatticeServiceDataSource_byName (28.28s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice	33.556s
    ewbankkit committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    089efe6 View commit details
    Browse the repository at this point in the history
  6. d/aws_vpclattice_service: Don't list tags when service has been RAM-s…

    …hared to the current account.
    ewbankkit committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    f7039a0 View commit details
    Browse the repository at this point in the history