Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the type of aws_codeartifact_domain asset_size_bytes to float … #32926

Merged

Conversation

misak113
Copy link
Contributor

@misak113 misak113 commented Aug 9, 2023

…(64) instead of int (32)

Because this value can get really big and the Integer (signed 32 size) can overflow. The maximum int32 value is 2147483647. See https://pkg.go.dev/builtin#int That is roughly 2 GBi of data that is easy to reach.

Example of error:

panic: Error reading level state: strconv.ParseInt: parsing "15679188538": value out of range

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Aug 9, 2023
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Hey @misak113 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

@github-actions github-actions bot added the service/codeartifact Issues and PRs that pertain to the codeartifact service. label Aug 9, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 9, 2023
…(64) instead of int (32)

Because this value can get really big and the Integer (signed 32 size) can overflow. The maximum int32 value is 2147483647. See https://pkg.go.dev/builtin#int
That is roughly 2 GBi of data that is easy to reach.

Example of error:
```
panic: Error reading level state: strconv.ParseInt: parsing "15679188538": value out of range
```
@misak113 misak113 force-pushed the b-aws-codeartifact-domain-asset_size_bytes branch from 3fa4032 to 835d577 Compare August 9, 2023 10:55
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @misak113 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 9, 2023
@nam054 nam054 self-assigned this Aug 11, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 11, 2023
@nam054 nam054 removed their assignment Aug 11, 2023
@johnsonaj johnsonaj self-assigned this Aug 25, 2023
@johnsonaj
Copy link
Contributor

@misak113 thank you for the contribution! 🎉 I incorporated your changes into a a new PR so that we could add tests

@johnsonaj johnsonaj merged commit de670bf into hashicorp:main Aug 29, 2023
69 checks passed
@github-actions github-actions bot added this to the v5.15.0 milestone Aug 29, 2023
@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Sep 1, 2023
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

This functionality has been released in v5.15.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/codeartifact Issues and PRs that pertain to the codeartifact service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants