DMS - Replication task - Allow date usage on cdc_start_time parameter

[jeremychauvet]

Description

This merge request introduce support of RFC3339 format date (eg: 2023-06-09T18:27:12Z) for the parameter cdc_start_time.

This is also the required format when creating a replication task (see --cdc-start-time) using the AWS CLI v2.

Relations

Closes #19801

References

• https://docs.aws.amazon.com/dms/latest/userguide/CHAP_Task.CDC.html
• https://awscli.amazonaws.com/v2/documentation/api/latest/reference/dms/create-replication-task.html

Output from Acceptance Testing

Unix timestamp

make testacc TESTS=TestAccDMSReplicationTask_cdcStartTime_unix_timestamp PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSReplicationTask_cdcStartTime_unix_timestamp'  -timeout 180m
=== RUN   TestAccDMSReplicationTask_cdcStartTime_unix_timestamp
=== PAUSE TestAccDMSReplicationTask_cdcStartTime_unix_timestamp
=== CONT  TestAccDMSReplicationTask_cdcStartTime_unix_timestamp
--- PASS: TestAccDMSReplicationTask_cdcStartTime_unix_timestamp (1051.69s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        1053.867s

RFC3339 date

make testacc TESTS=TestAccDMSReplicationTask_cdcStartTime_rfc3339_date PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSReplicationTask_cdcStartTime_rfc3339_date'  -timeout 180m
=== RUN   TestAccDMSReplicationTask_cdcStartTime_rfc3339_date
=== PAUSE TestAccDMSReplicationTask_cdcStartTime_rfc3339_date
=== CONT  TestAccDMSReplicationTask_cdcStartTime_rfc3339_date
--- PASS: TestAccDMSReplicationTask_cdcStartTime_rfc3339_date (1062.81s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        1064.967s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[gdavison]

Thanks for the PR, @jeremychauvet. We could get around the breaking change by accepting either the existing Unix timestamp or an RFC 3339 date. The validation function verify.ValidStringDateOrPositiveInt can be used for this, and is in use in a few resources.

[jeremychauvet]

Thanks for the feedback @gdavison 🙏🏼
Changing code to use it 🚀

[jeremychauvet]

Code updated, added new tests to match it:

make testacc TESTS=TestAccDMSReplicationTask_cdcStartTime_unix_timestamp PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSReplicationTask_cdcStartTime_unix_timestamp'  -timeout 180m
=== RUN   TestAccDMSReplicationTask_cdcStartTime_unix_timestamp
=== PAUSE TestAccDMSReplicationTask_cdcStartTime_unix_timestamp
=== CONT  TestAccDMSReplicationTask_cdcStartTime_unix_timestamp
--- PASS: TestAccDMSReplicationTask_cdcStartTime_unix_timestamp (1051.69s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        1053.867s

make testacc TESTS=TestAccDMSReplicationTask_cdcStartTime_rfc3339_date PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSReplicationTask_cdcStartTime_rfc3339_date'  -timeout 180m
=== RUN   TestAccDMSReplicationTask_cdcStartTime_rfc3339_date
=== PAUSE TestAccDMSReplicationTask_cdcStartTime_rfc3339_date
=== CONT  TestAccDMSReplicationTask_cdcStartTime_rfc3339_date
--- PASS: TestAccDMSReplicationTask_cdcStartTime_rfc3339_date (1062.81s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        1064.967s

[jeremychauvet]

PR ready for review ✅

[ewbankkit]

@jeremychauvet Thanks for the contribution 🎉 👏.
These changes have been rolled into #34356.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.