Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sagemaker workforce - vpc support #27538

Merged
merged 6 commits into from
Oct 31, 2022
Merged

Sagemaker workforce - vpc support #27538

merged 6 commits into from
Oct 31, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Oct 28, 2022 •
edited
Loading

Description

Add support for VPC config for sagemaker workforce.

Relations

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccSageMaker_serial/Workforce PKG=sagemaker

--- PASS: TestAccSageMaker_serial (641.34s)
    --- PASS: TestAccSageMaker_serial/Workforce (641.34s)
        --- PASS: TestAccSageMaker_serial/Workforce/OidcConfig (67.75s)
        --- PASS: TestAccSageMaker_serial/Workforce/SourceIpConfig (114.52s)
        --- PASS: TestAccSageMaker_serial/Workforce/VPC (366.91s)
        --- PASS: TestAccSageMaker_serial/Workforce/disappears (43.61s)
        --- PASS: TestAccSageMaker_serial/Workforce/CognitoConfig (48.55s)

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/sagemaker Issues and PRs that pertain to the sagemaker service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 28, 2022
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 28, 2022
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed enhancement Requests to existing resources that expand the functionality or scope. documentation Introduces or discusses updates to documentation. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. sweeper Pertains to changes to or issues with the sweeper. labels Oct 28, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review October 28, 2022 18:44
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. sweeper Pertains to changes to or issues with the sweeper. labels Oct 28, 2022
@DrFaust92 DrFaust92 force-pushed the sagemaker-workforce-vpc-config branch from 9265b5a to 760808c Compare October 28, 2022 21:15
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Oct 28, 2022
ewbankkit
ewbankkit approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccSageMaker_serial/Workforce PKG=sagemaker
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccSageMaker_serial/Workforce'  -timeout 180m
=== RUN   TestAccSageMaker_serial
=== RUN   TestAccSageMaker_serial/Workforce
=== RUN   TestAccSageMaker_serial/Workforce/disappears
=== RUN   TestAccSageMaker_serial/Workforce/CognitoConfig
=== RUN   TestAccSageMaker_serial/Workforce/OidcConfig
=== RUN   TestAccSageMaker_serial/Workforce/SourceIpConfig
=== RUN   TestAccSageMaker_serial/Workforce/VPC
--- PASS: TestAccSageMaker_serial (519.65s)
    --- PASS: TestAccSageMaker_serial/Workforce (519.65s)
        --- PASS: TestAccSageMaker_serial/Workforce/disappears (26.18s)
        --- PASS: TestAccSageMaker_serial/Workforce/CognitoConfig (26.51s)
        --- PASS: TestAccSageMaker_serial/Workforce/OidcConfig (42.77s)
        --- PASS: TestAccSageMaker_serial/Workforce/SourceIpConfig (57.41s)
        --- PASS: TestAccSageMaker_serial/Workforce/VPC (366.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	523.775s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 990f9ae into hashicorp:main Oct 31, 2022
@github-actions github-actions bot added this to the v4.38.0 milestone Oct 31, 2022
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

This functionality has been released in v4.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Dec 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/L Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.38.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DrFaust92 @ewbankkit