Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_subnet_ids: Deprecate #22743

Merged
merged 5 commits into from
Feb 1, 2022
Merged

d/aws_subnet_ids: Deprecate #22743

merged 5 commits into from
Feb 1, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jan 24, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20592.
Relates #20433.
Relates #22818.

Output from acceptance testing:

% make testacc TESTS=TestAccEC2SubnetIDsDataSource_ PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2SubnetIDsDataSource_'  -timeout 180m
=== RUN   TestAccEC2SubnetIDsDataSource_basic
=== PAUSE TestAccEC2SubnetIDsDataSource_basic
=== RUN   TestAccEC2SubnetIDsDataSource_filter
=== PAUSE TestAccEC2SubnetIDsDataSource_filter
=== CONT  TestAccEC2SubnetIDsDataSource_basic
=== CONT  TestAccEC2SubnetIDsDataSource_filter
--- PASS: TestAccEC2SubnetIDsDataSource_filter (27.38s)
--- PASS: TestAccEC2SubnetIDsDataSource_basic (40.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	44.562s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. labels Jan 24, 2022
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple text updates, otherwise LGTM

.changelog/22743.txt Outdated Show resolved Hide resolved
internal/service/ec2/subnet_ids_data_source.go Outdated Show resolved Hide resolved
website/docs/d/subnet_ids.html.markdown Outdated Show resolved Hide resolved
@ewbankkit ewbankkit merged commit b066229 into main Feb 1, 2022
@ewbankkit ewbankkit deleted the d/aws_subnet_ids-deprecated branch February 1, 2022 20:49
@github-actions github-actions bot added this to the v4.0.0 milestone Feb 1, 2022
github-actions bot pushed a commit that referenced this pull request Feb 1, 2022
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

d/aws_subnet_ids: Deprecate in favor of aws_subnets data source
2 participants