Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Terraform syntax for data source acceptance tests #14837

Merged
merged 2 commits into from
Aug 28, 2020
Merged

Updates Terraform syntax for data source acceptance tests #14837

merged 2 commits into from
Aug 28, 2020

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Aug 25, 2020 •
edited
Loading

Updates Terraform syntax for data source acceptance tests.

Relates #14417

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAcmCertificateDataSource\|TestAccDataSourceAWSLBTargetGroup\|TestAccDataSourceAWSMqBroker\|TestAccDataSourceAwsVpcDhcpOptions\|TestAccAWSInstancesDataSource\|TestAccDataSourceAwsSecurityGroups\|TestAccAWSProvider\|TestAccDataSourceCloudHsmV2Cluster\|TestAccDataSourceAWSALBTargetGroup\|TestAccAWSInstanceDataSource\|TestAccDataSourceAWSELB\|TestAccDataSourceAWSLBListener\|TestAccDataSourceAWSLB\|TestAccDataSourceAwsNetworkAcls'

--- PASS: TestAccAWSAcmCertificateDataSource_KeyTypes (52.87s)
--- SKIP: TestAccAWSAcmCertificateDataSource_multipleIssued (0.00s)
--- SKIP: TestAccAWSAcmCertificateDataSource_noMatchReturnsError (0.00s)
--- SKIP: TestAccAWSAcmCertificateDataSource_singleIssued (0.00s)
--- PASS: TestAccAWSInstanceDataSource_AzUserData (99.12s)
--- PASS: TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId (130.98s)
--- PASS: TestAccAWSInstanceDataSource_GetUserData (123.41s)
--- PASS: TestAccAWSInstanceDataSource_GetUserData_NoUserData (108.84s)
--- PASS: TestAccAWSInstanceDataSource_PlacementGroup (70.24s)
--- PASS: TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId (141.05s)
--- PASS: TestAccAWSInstanceDataSource_SecurityGroups (116.88s)
--- PASS: TestAccAWSInstanceDataSource_VPC (103.35s)
--- PASS: TestAccAWSInstanceDataSource_VPCSecurityGroups (113.00s)
--- PASS: TestAccAWSInstanceDataSource_basic (99.05s)
--- PASS: TestAccAWSInstanceDataSource_blockDevices (88.63s)
--- PASS: TestAccAWSInstanceDataSource_creditSpecification (85.12s)
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_falseToTrue (144.27s)
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_trueToFalse (166.43s)
--- PASS: TestAccAWSInstanceDataSource_gp2IopsDevice (87.02s)
--- PASS: TestAccAWSInstanceDataSource_keyPair (97.24s)
--- PASS: TestAccAWSInstanceDataSource_metadataOptions (86.63s)
--- PASS: TestAccAWSInstanceDataSource_privateIP (112.32s)
--- PASS: TestAccAWSInstanceDataSource_rootInstanceStore (335.98s)
--- PASS: TestAccAWSInstanceDataSource_secondaryPrivateIPs (103.11s)
--- PASS: TestAccAWSInstanceDataSource_tags (106.10s)
--- PASS: TestAccAWSInstancesDataSource_basic (195.62s)
--- PASS: TestAccAWSInstancesDataSource_instance_state_names (196.59s)
--- PASS: TestAccAWSInstancesDataSource_tags (195.92s)
--- PASS: TestAccAWSProvider_AssumeRole_Empty (13.01s)
--- PASS: TestAccAWSProvider_Endpoints (18.83s)
--- PASS: TestAccAWSProvider_IgnoreTags_EmptyConfigurationBlock (19.75s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_Multiple (19.50s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_None (18.76s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_One (18.14s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_Multiple (19.22s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_None (19.38s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_One (20.07s)
--- PASS: TestAccAWSProvider_Region_AwsChina (15.97s)
--- PASS: TestAccAWSProvider_Region_AwsCommercial (15.16s)
--- PASS: TestAccAWSProvider_Region_AwsGovCloudUs (11.15s)
--- PASS: TestAccDataSourceAWSALBTargetGroup_basic (198.56s)
--- PASS: TestAccDataSourceAWSELB_basic (34.02s)
--- PASS: TestAccDataSourceAWSLBListener_BackwardsCompatibility (206.44s)
--- PASS: TestAccDataSourceAWSLBListener_basic (195.62s)
--- PASS: TestAccDataSourceAWSLBListener_https (198.84s)
--- PASS: TestAccDataSourceAWSLBTargetGroup_BackwardsCompatibility (207.36s)
--- PASS: TestAccDataSourceAWSLB_BackwardsCompatibility (207.32s)
--- PASS: TestAccDataSourceAWSLB_basic (199.34s)
--- PASS: TestAccDataSourceAWSMqBroker_basic (1185.23s)
--- PASS: TestAccDataSourceAwsNetworkAcls_Filter (14.64s)
--- PASS: TestAccDataSourceAwsNetworkAcls_Tags (18.57s)
--- PASS: TestAccDataSourceAwsNetworkAcls_VpcID (17.88s)
--- PASS: TestAccDataSourceAwsNetworkAcls_basic (25.60s)
--- PASS: TestAccDataSourceAwsSecurityGroups_filter (22.95s)
--- PASS: TestAccDataSourceAwsSecurityGroups_tag (20.14s)
--- PASS: TestAccDataSourceAwsVpcDhcpOptions_Filter (44.43s)
--- PASS: TestAccDataSourceAwsVpcDhcpOptions_basic (25.49s)
--- PASS: TestAccDataSourceCloudHsmV2Cluster_basic (287.00s)

@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/acm Issues and PRs that pertain to the acm service. service/ec2 Issues and PRs that pertain to the ec2 service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/mq Issues and PRs that pertain to the mq service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 25, 2020
@gdavison gdavison marked this pull request as ready for review August 26, 2020 00:27
@gdavison gdavison requested a review from a team August 26, 2020 00:27
@bflad bflad self-assigned this Aug 28, 2020
@bflad
Copy link
Contributor

bflad commented Aug 28, 2020

Closes #14561 (will link issue in a sec)

@bflad bflad linked an issue Aug 28, 2020 that may be closed by this pull request
tests/data-source/aws_vpc_dhcp_options: TestAccDataSourceAwsVpcDhcpOptions_Filter Failures #14561
Closed
1 task
bflad
bflad approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀

Output from acceptance testing:

--- PASS: TestAccAWSAcmCertificateDataSource_KeyTypes (29.05s)

--- PASS: TestAccAWSInstanceDataSource_AzUserData (113.38s)
--- PASS: TestAccAWSInstanceDataSource_basic (102.48s)
--- PASS: TestAccAWSInstanceDataSource_blockDevices (79.84s)
--- PASS: TestAccAWSInstanceDataSource_creditSpecification (84.89s)
--- PASS: TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId (80.18s)
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_falseToTrue (217.91s)
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_trueToFalse (198.77s)
--- PASS: TestAccAWSInstanceDataSource_GetUserData (122.75s)
--- PASS: TestAccAWSInstanceDataSource_GetUserData_NoUserData (122.91s)
--- PASS: TestAccAWSInstanceDataSource_gp2IopsDevice (99.48s)
--- PASS: TestAccAWSInstanceDataSource_keyPair (103.10s)
--- PASS: TestAccAWSInstanceDataSource_metadataOptions (77.89s)
--- PASS: TestAccAWSInstanceDataSource_PlacementGroup (76.44s)
--- PASS: TestAccAWSInstanceDataSource_privateIP (103.89s)
--- PASS: TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId (110.43s)
--- PASS: TestAccAWSInstanceDataSource_rootInstanceStore (78.83s)
--- PASS: TestAccAWSInstanceDataSource_secondaryPrivateIPs (105.76s)
--- PASS: TestAccAWSInstanceDataSource_SecurityGroups (106.03s)
--- PASS: TestAccAWSInstanceDataSource_tags (96.40s)
--- PASS: TestAccAWSInstanceDataSource_VPC (104.42s)
--- PASS: TestAccAWSInstanceDataSource_VPCSecurityGroups (114.49s)

--- PASS: TestAccAWSInstancesDataSource_basic (81.10s)
--- PASS: TestAccAWSInstancesDataSource_instance_state_names (77.08s)
--- PASS: TestAccAWSInstancesDataSource_tags (81.14s)

--- PASS: TestAccAWSProvider_AssumeRole_Empty (21.70s)
--- PASS: TestAccAWSProvider_Endpoints (28.39s)
--- PASS: TestAccAWSProvider_IgnoreTags_EmptyConfigurationBlock (25.47s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_Multiple (27.07s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_None (28.15s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_One (28.17s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_Multiple (22.78s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_None (26.76s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_One (25.43s)
--- PASS: TestAccAWSProvider_Region_AwsChina (19.01s)
--- PASS: TestAccAWSProvider_Region_AwsCommercial (19.50s)
--- PASS: TestAccAWSProvider_Region_AwsGovCloudUs (18.59s)

--- PASS: TestAccDataSourceAWSALBTargetGroup_basic (204.73s)

--- PASS: TestAccDataSourceAWSELB_basic (35.99s)

--- PASS: TestAccDataSourceAWSLB_BackwardsCompatibility (190.18s)
--- PASS: TestAccDataSourceAWSLB_basic (201.86s)

--- PASS: TestAccDataSourceAWSLBListener_BackwardsCompatibility (212.98s)
--- PASS: TestAccDataSourceAWSLBListener_basic (199.22s)
--- PASS: TestAccDataSourceAWSLBListener_https (191.53s)

--- PASS: TestAccDataSourceAWSLBTargetGroup_BackwardsCompatibility (212.46s)

--- PASS: TestAccDataSourceAWSMqBroker_basic (1203.59s)

--- PASS: TestAccDataSourceAwsNetworkAcls_basic (31.91s)
--- PASS: TestAccDataSourceAwsNetworkAcls_Filter (21.30s)
--- PASS: TestAccDataSourceAwsNetworkAcls_Tags (15.19s)
--- PASS: TestAccDataSourceAwsNetworkAcls_VpcID (19.49s)

--- PASS: TestAccDataSourceAwsSecurityGroups_filter (29.54s)
--- PASS: TestAccDataSourceAwsSecurityGroups_tag (28.10s)

--- PASS: TestAccDataSourceAwsVpcDhcpOptions_basic (33.86s)
--- PASS: TestAccDataSourceAwsVpcDhcpOptions_Filter (54.84s)

--- PASS: TestAccDataSourceCloudHsmV2Cluster_basic (282.12s)

aws/data_source_aws_cloudhsm2_cluster_test.go
@@ -59,7 +59,7 @@ resource "aws_subnet" "cloudhsm_v2_test_subnets" {

resource "aws_cloudhsm_v2_cluster" "cluster" {
hsm_type = "hsm1.medium"
subnet_ids = [aws_subnet.cloudhsm_v2_test_subnets.0.id, aws_subnet.cloudhsm_v2_test_subnets.1.id]
subnet_ids = aws_subnet.cloudhsm_v2_test_subnets[*].id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@gdavison gdavison merged commit 5f7bdf7 into master Aug 28, 2020
@gdavison gdavison deleted the acctest-ftlint-datasources branch August 28, 2020 23:15
@gdavison gdavison mentioned this pull request Sep 11, 2020
Merged
@ghost
Copy link

ghost commented Sep 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 28, 2020
@breathingdust breathingdust added this to the v3.5.0 milestone Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
service/acm Issues and PRs that pertain to the acm service. service/ec2 Issues and PRs that pertain to the ec2 service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/mq Issues and PRs that pertain to the mq service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

tests/data-source/aws_vpc_dhcp_options: TestAccDataSourceAwsVpcDhcpOptions_Filter Failures
3 participants
@gdavison @bflad @breathingdust