d/aws_launch_template: Change 'network_interfaces.delete_on_termination' to TypeString, matching associated resource

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14597.

Release note for CHANGELOG:

data-source/aws_launch_template: Fix error with `delete_on_termination` attribute of `network_interfaces` block

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLaunchTemplateDataSource_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLaunchTemplateDataSource_ -timeout 120m
=== RUN   TestAccAWSLaunchTemplateDataSource_basic
=== PAUSE TestAccAWSLaunchTemplateDataSource_basic
=== RUN   TestAccAWSLaunchTemplateDataSource_filter_basic
=== PAUSE TestAccAWSLaunchTemplateDataSource_filter_basic
=== RUN   TestAccAWSLaunchTemplateDataSource_filter_tags
=== PAUSE TestAccAWSLaunchTemplateDataSource_filter_tags
=== RUN   TestAccAWSLaunchTemplateDataSource_metadataOptions
=== PAUSE TestAccAWSLaunchTemplateDataSource_metadataOptions
=== RUN   TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress
=== PAUSE TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress
=== RUN   TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination
=== PAUSE TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination
=== RUN   TestAccAWSLaunchTemplateDataSource_NonExistent
=== PAUSE TestAccAWSLaunchTemplateDataSource_NonExistent
=== CONT  TestAccAWSLaunchTemplateDataSource_basic
=== CONT  TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress
=== CONT  TestAccAWSLaunchTemplateDataSource_metadataOptions
=== CONT  TestAccAWSLaunchTemplateDataSource_filter_tags
=== CONT  TestAccAWSLaunchTemplateDataSource_filter_basic
=== CONT  TestAccAWSLaunchTemplateDataSource_NonExistent
=== CONT  TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination
--- PASS: TestAccAWSLaunchTemplateDataSource_NonExistent (5.71s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_tags (32.77s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_basic (32.93s)
--- PASS: TestAccAWSLaunchTemplateDataSource_basic (33.17s)
--- PASS: TestAccAWSLaunchTemplateDataSource_metadataOptions (33.21s)
--- PASS: TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress (63.82s)
--- PASS: TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination (64.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	64.211s

[anGie44]

Looks great, thanks for this fix @ewbankkit!

Output of acceptance tests:

--- PASS: TestAccAWSLaunchTemplateDataSource_NonExistent (4.10s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_basic (16.44s)
--- PASS: TestAccAWSLaunchTemplateDataSource_metadataOptions (16.52s)
--- PASS: TestAccAWSLaunchTemplateDataSource_basic (16.75s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_tags (17.04s)
--- PASS: TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress (42.30s)
--- PASS: TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination (42.30s)

Noting similar rationale to merge this PR as #12936 (comment)

[ghost]

This has been released in version 3.2.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!