Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_apigatewayv2_stage: 'data_trace_enabled' and 'logging_level' are only valid for WebSocket APIs #13809

Merged
merged 9 commits into from
Jul 24, 2020
Merged

r/aws_apigatewayv2_stage: 'data_trace_enabled' and 'logging_level' are only valid for WebSocket APIs #13809

merged 9 commits into from
Jul 24, 2020

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jun 17, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13801.
Relates #13527.

Release note for CHANGELOG:

resource/aws_apigatewayv2_stage: Correctly handle `default_route_setting` and `route_setting` `data_trace_enabled` and `logging_level` for HTTP APIs. `logging_level` is now `Computed`, meaning Terraform will only perform drift detection of its value when present in a configuration.

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Stage_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Stage_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2Stage_basicWebSocket
=== PAUSE TestAccAWSAPIGatewayV2Stage_basicWebSocket
=== RUN   TestAccAWSAPIGatewayV2Stage_basicHttp
=== PAUSE TestAccAWSAPIGatewayV2Stage_basicHttp
=== RUN   TestAccAWSAPIGatewayV2Stage_defaultHttpStage
=== PAUSE TestAccAWSAPIGatewayV2Stage_defaultHttpStage
=== RUN   TestAccAWSAPIGatewayV2Stage_disappears
=== PAUSE TestAccAWSAPIGatewayV2Stage_disappears
=== RUN   TestAccAWSAPIGatewayV2Stage_AccessLogSettings
=== PAUSE TestAccAWSAPIGatewayV2Stage_AccessLogSettings
=== RUN   TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription
=== PAUSE TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription
=== RUN   TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsWebSocket
=== PAUSE TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsWebSocket
=== RUN   TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsHttp
=== PAUSE TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsHttp
=== RUN   TestAccAWSAPIGatewayV2Stage_Deployment
=== PAUSE TestAccAWSAPIGatewayV2Stage_Deployment
=== RUN   TestAccAWSAPIGatewayV2Stage_RouteSettingsWebSocket
=== PAUSE TestAccAWSAPIGatewayV2Stage_RouteSettingsWebSocket
=== RUN   TestAccAWSAPIGatewayV2Stage_RouteSettingsHttp
=== PAUSE TestAccAWSAPIGatewayV2Stage_RouteSettingsHttp
=== RUN   TestAccAWSAPIGatewayV2Stage_StageVariables
=== PAUSE TestAccAWSAPIGatewayV2Stage_StageVariables
=== RUN   TestAccAWSAPIGatewayV2Stage_Tags
=== PAUSE TestAccAWSAPIGatewayV2Stage_Tags
=== CONT  TestAccAWSAPIGatewayV2Stage_basicWebSocket
=== CONT  TestAccAWSAPIGatewayV2Stage_Tags
=== CONT  TestAccAWSAPIGatewayV2Stage_StageVariables
=== CONT  TestAccAWSAPIGatewayV2Stage_RouteSettingsHttp
=== CONT  TestAccAWSAPIGatewayV2Stage_RouteSettingsWebSocket
=== CONT  TestAccAWSAPIGatewayV2Stage_Deployment
=== CONT  TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsHttp
=== CONT  TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsWebSocket
=== CONT  TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription
=== CONT  TestAccAWSAPIGatewayV2Stage_AccessLogSettings
=== CONT  TestAccAWSAPIGatewayV2Stage_disappears
=== CONT  TestAccAWSAPIGatewayV2Stage_defaultHttpStage
=== CONT  TestAccAWSAPIGatewayV2Stage_basicHttp
--- PASS: TestAccAWSAPIGatewayV2Stage_disappears (27.88s)
--- PASS: TestAccAWSAPIGatewayV2Stage_basicWebSocket (32.97s)
--- PASS: TestAccAWSAPIGatewayV2Stage_defaultHttpStage (33.62s)
--- PASS: TestAccAWSAPIGatewayV2Stage_basicHttp (33.94s)
--- PASS: TestAccAWSAPIGatewayV2Stage_RouteSettingsWebSocket (51.24s)
--- PASS: TestAccAWSAPIGatewayV2Stage_RouteSettingsHttp (51.90s)
--- PASS: TestAccAWSAPIGatewayV2Stage_StageVariables (52.18s)
--- PASS: TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsWebSocket (52.24s)
--- PASS: TestAccAWSAPIGatewayV2Stage_Tags (52.35s)
--- PASS: TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsHttp (52.43s)
--- PASS: TestAccAWSAPIGatewayV2Stage_Deployment (63.90s)
--- PASS: TestAccAWSAPIGatewayV2Stage_AccessLogSettings (73.62s)
--- PASS: TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription (108.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	108.789s

@ewbankkit ewbankkit requested a review from a team June 17, 2020 20:37
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 17, 2020
@ewbankkit ewbankkit changed the title r/aws_apigatewayv2_stage: 'data_trace_enabled' and 'logging_level' are only valid for WebSocket APIs [WIP] r/aws_apigatewayv2_stage: 'data_trace_enabled' and 'logging_level' are only valid for WebSocket APIs Jun 17, 2020
@ewbankkit ewbankkit changed the title [WIP] r/aws_apigatewayv2_stage: 'data_trace_enabled' and 'logging_level' are only valid for WebSocket APIs r/aws_apigatewayv2_stage: 'data_trace_enabled' and 'logging_level' are only valid for WebSocket APIs Jun 17, 2020
@anGie44 anGie44 self-requested a review June 17, 2020 22:10
anGie44
anGie44 reviewed Jun 18, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ewbankkit, thanks for this PR! Just a comment regarding the DiffSuppressFunc given some results I found in testing.

Output of acceptance tests:

--- PASS: TestAccAWSAPIGatewayV2Stage_defaultHttpStage (13.59s)
--- PASS: TestAccAWSAPIGatewayV2Stage_basicWebSocket (13.57s)
--- PASS: TestAccAWSAPIGatewayV2Stage_Tags (18.70s)
--- PASS: TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsWebSocket (19.03s)
--- PASS: TestAccAWSAPIGatewayV2Stage_RouteSettingsWebSocket (27.90s)
--- PASS: TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription (28.61s)
--- PASS: TestAccAWSAPIGatewayV2Stage_RouteSettingsHttp (28.67s)
--- PASS: TestAccAWSAPIGatewayV2Stage_disappears (39.76s)
--- PASS: TestAccAWSAPIGatewayV2Stage_basicHttp (42.55s)
--- PASS: TestAccAWSAPIGatewayV2Stage_Deployment (43.88s)
--- PASS: TestAccAWSAPIGatewayV2Stage_StageVariables (47.17s)
--- PASS: TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsHttp (48.11s)
--- PASS: TestAccAWSAPIGatewayV2Stage_AccessLogSettings (48.50s)

aws/resource_aws_apigatewayv2_stage.go Outdated
@@ -99,7 +99,7 @@ func resourceAwsApiGatewayV2Stage() *schema.Resource {
}, false),
DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool {
// Not set for HTTP APIs.
if old == "" && new == apigatewayv2.LoggingLevelOff {
if d.Id() != "" && old == "" && new == apigatewayv2.LoggingLevelOff {
Copy link
Contributor

@anGie44 anGie44 Jun 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar comment as below but with regard to this default block

aws/resource_aws_apigatewayv2_stage.go Outdated
@@ -164,6 +164,13 @@ func resourceAwsApiGatewayV2Stage() *schema.Resource {
apigatewayv2.LoggingLevelInfo,
apigatewayv2.LoggingLevelOff,
}, false),
DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool {
// Not set for HTTP APIs.
if d.Id() != "" && old == "" && new == apigatewayv2.LoggingLevelOff {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Playing around with this branch, I noticed that this line will affect subsequent updates made to the route_settings blocks (not sure how common of a use-case that is); but taking from TestAccAWSAPIGatewayV2Stage_RouteSettingsWebSocket, if say in step 2 we don't remove the route_settings blocks but rather adjust a field in the first route_settings block (route_key = "$default") to update the throttling_bursting_limit or throttling_rate_limit to a value other than 0, the test returns

TestAccAWSAPIGatewayV2Stage_RouteSettingsWebSocket: testing.go:684: Step 2 error: Check failed: Check 15/18 error: "aws_apigatewayv2_stage.test" no TypeSet element "route_settings.*", with nested attrs map[string]string{"data_trace_enabled":"false", "detailed_metrics_enabled":"false", "logging_level":"OFF", "route_key":"$default", "throttling_burst_limit":"2225", "throttling_rate_limit":"8888"}

such that the logging_level is expect to be "OFF" but in state it's stored as "":

... in state: map[string]string{..., "route_settings.1709803393.logging_level":"", "route_settings.1709803393.route_key":"$default", "route_settings.1709803393.throttling_burst_limit":"2225", "route_settings.1709803393.throttling_rate_limit":"8888",

if you swap d.Id() != "" with !d.IsNewResource() the test passes, however, given the logging_level checked in tfawsresource.TestCheckTypeSetElemNestedAttrs() is expected to be the empty string "" (instead of "INFO" as is at the moment)

in this scenario, I'm not sure what the proper behavior/state should be that satisfies both WebSocket and HTTP API stages. would it make sense for the WebSocket stage to show logging_level = "" in state if technically it's permissable to have this set to "OFF" unlike in HTTP stages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I added the d.Id() != "" so as to avoid changes from "OFF" to '""` in the WebSocket test 😄. I'll take another look at this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, thanks for taking a look! in general, it does seem tricky though since we're working around the Default in place.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, if we could just change to no Default this wold be simpler.
The stumbling block now is the route_settings set hash function not understanding the suppressed fields...

@ewbankkit ewbankkit changed the title r/aws_apigatewayv2_stage: 'data_trace_enabled' and 'logging_level' are only valid for WebSocket APIs [WIP] r/aws_apigatewayv2_stage: 'data_trace_enabled' and 'logging_level' are only valid for WebSocket APIs Jun 18, 2020
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jun 19, 2020
@ewbankkit ewbankkit mentioned this pull request Jul 1, 2020
Closed
@reyescameron17
Copy link

reyescameron17 commented Jul 20, 2020 •
edited
Loading

Any updates on when this might be merged? I'm assuming the PR has become stale due to a month passing since last commit. This blocks creating/updating an HTTP api gateway using TF.

@ewbankkit
Copy link
Contributor Author

@reyescameron17 Not gone stale, just swapped out for a bit 😄.
I am starting to think that changing these attributes to Computed: true, may be the way forward.

@ewbankkit
r/aws_apigatewayv2_stage: 'data_trace_enabled' and 'logging_level' ar…
3efa7c7 
…e only valid for WebSocket APIs.
@ewbankkit
r/aws_apigatewayv2_stage: No need for diff-suppression for new resour…
37230b7 
…ces.
@ewbankkit
r/aws_apigatewayv2_stage: Additional route_settings and default_route…
69c328e 
…_settings test cases.
@ewbankkit
r/aws_apigatewayv2_stage: Add computed 'api_protocol_type' attribute.
7e3e2a7
@ewbankkit
r/aws_apigatewayv2_stage: Pass API protocol type to 'flattenApiGatewa…
1fff9c2 
…yV2RouteSettings'.
@ewbankkit
Revert "r/aws_apigatewayv2_stage: Pass API protocol type to 'flattenA…
eaa6111 
…piGatewayV2RouteSettings'."

This reverts commit 9337272b7842879cdbae5be19ec076bea314b20c.
@ewbankkit
Revert "r/aws_apigatewayv2_stage: Add computed 'api_protocol_type' at…
c755087 
…tribute."

This reverts commit a7eb7cf9976ecabb04696dbe2f39805cc0ec1401.
@ewbankkit
Fix mess from rebase.
e735282
@ewbankkit
r/aws_apigatewayv2_stage: Change 'route_setting.logging_level' to com…
659a511 
…puted to address different defaults for WebSocket vs. HTTP.
@ewbankkit ewbankkit force-pushed the b-aws_apigatewayv2_stage-http-route-settings branch from b719c15 to 659a511 Compare July 21, 2020 20:41
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Jul 21, 2020
@ewbankkit ewbankkit changed the title [WIP] r/aws_apigatewayv2_stage: 'data_trace_enabled' and 'logging_level' are only valid for WebSocket APIs r/aws_apigatewayv2_stage: 'data_trace_enabled' and 'logging_level' are only valid for WebSocket APIs Jul 21, 2020
@ewbankkit
Copy link
Contributor Author

Rebased to fix merge conflicts and changed logging_level to Compted: true.
Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Stage_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Stage_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2Stage_basicWebSocket
=== PAUSE TestAccAWSAPIGatewayV2Stage_basicWebSocket
=== RUN   TestAccAWSAPIGatewayV2Stage_basicHttp
=== PAUSE TestAccAWSAPIGatewayV2Stage_basicHttp
=== RUN   TestAccAWSAPIGatewayV2Stage_defaultHttpStage
=== PAUSE TestAccAWSAPIGatewayV2Stage_defaultHttpStage
=== RUN   TestAccAWSAPIGatewayV2Stage_disappears
=== PAUSE TestAccAWSAPIGatewayV2Stage_disappears
=== RUN   TestAccAWSAPIGatewayV2Stage_AccessLogSettings
=== PAUSE TestAccAWSAPIGatewayV2Stage_AccessLogSettings
=== RUN   TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription
=== PAUSE TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription
=== RUN   TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsWebSocket
=== PAUSE TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsWebSocket
=== RUN   TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsHttp
=== PAUSE TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsHttp
=== RUN   TestAccAWSAPIGatewayV2Stage_Deployment
=== PAUSE TestAccAWSAPIGatewayV2Stage_Deployment
=== RUN   TestAccAWSAPIGatewayV2Stage_RouteSettingsWebSocket
=== PAUSE TestAccAWSAPIGatewayV2Stage_RouteSettingsWebSocket
=== RUN   TestAccAWSAPIGatewayV2Stage_RouteSettingsHttp
=== PAUSE TestAccAWSAPIGatewayV2Stage_RouteSettingsHttp
=== RUN   TestAccAWSAPIGatewayV2Stage_StageVariables
=== PAUSE TestAccAWSAPIGatewayV2Stage_StageVariables
=== RUN   TestAccAWSAPIGatewayV2Stage_Tags
=== PAUSE TestAccAWSAPIGatewayV2Stage_Tags
=== CONT  TestAccAWSAPIGatewayV2Stage_basicWebSocket
=== CONT  TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsHttp
=== CONT  TestAccAWSAPIGatewayV2Stage_Tags
=== CONT  TestAccAWSAPIGatewayV2Stage_StageVariables
=== CONT  TestAccAWSAPIGatewayV2Stage_RouteSettingsHttp
=== CONT  TestAccAWSAPIGatewayV2Stage_RouteSettingsWebSocket
=== CONT  TestAccAWSAPIGatewayV2Stage_Deployment
=== CONT  TestAccAWSAPIGatewayV2Stage_AccessLogSettings
=== CONT  TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsWebSocket
=== CONT  TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription
=== CONT  TestAccAWSAPIGatewayV2Stage_defaultHttpStage
=== CONT  TestAccAWSAPIGatewayV2Stage_disappears
=== CONT  TestAccAWSAPIGatewayV2Stage_basicHttp
--- PASS: TestAccAWSAPIGatewayV2Stage_disappears (16.92s)
--- PASS: TestAccAWSAPIGatewayV2Stage_basicHttp (20.92s)
--- PASS: TestAccAWSAPIGatewayV2Stage_defaultHttpStage (21.32s)
--- PASS: TestAccAWSAPIGatewayV2Stage_basicWebSocket (23.12s)
--- PASS: TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription (29.92s)
--- PASS: TestAccAWSAPIGatewayV2Stage_Tags (31.47s)
--- PASS: TestAccAWSAPIGatewayV2Stage_StageVariables (31.97s)
--- PASS: TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsHttp (40.74s)
--- PASS: TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsWebSocket (41.10s)
--- PASS: TestAccAWSAPIGatewayV2Stage_RouteSettingsHttp (41.14s)
--- PASS: TestAccAWSAPIGatewayV2Stage_AccessLogSettings (52.82s)
--- PASS: TestAccAWSAPIGatewayV2Stage_RouteSettingsWebSocket (67.46s)
--- PASS: TestAccAWSAPIGatewayV2Stage_Deployment (69.21s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	69.323s

@ewbankkit
Copy link
Contributor Author

@anGie44 The only solution here seems to be to change the logging_level attributes to Computed and note that in the documentation and release notes. I don't think this is a breaking change.

anGie44
anGie44 approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @ewbankkit! LGTM 🚀

Output of acceptance tests:

--- PASS: TestAccAWSAPIGatewayV2Stage_basicWebSocket (12.87s)
--- PASS: TestAccAWSAPIGatewayV2Stage_defaultHttpStage (13.41s)
--- PASS: TestAccAWSAPIGatewayV2Stage_Tags (17.66s)
--- PASS: TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription (19.93s)
--- PASS: TestAccAWSAPIGatewayV2Stage_StageVariables (21.03s)
--- PASS: TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsHttp (25.00s)
--- PASS: TestAccAWSAPIGatewayV2Stage_RouteSettingsHttp (25.80s)
--- PASS: TestAccAWSAPIGatewayV2Stage_RouteSettingsWebSocket (32.76s)
--- PASS: TestAccAWSAPIGatewayV2Stage_disappears (41.60s)
--- PASS: TestAccAWSAPIGatewayV2Stage_Deployment (42.95s)
--- PASS: TestAccAWSAPIGatewayV2Stage_basicHttp (43.25s)
--- PASS: TestAccAWSAPIGatewayV2Stage_AccessLogSettings (51.01s)
--- PASS: TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsWebSocket (52.52s)

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @ewbankkit

Verified Acceptance Tests (Commercial)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Stage_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Stage_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2Stage_basicWebSocket
=== PAUSE TestAccAWSAPIGatewayV2Stage_basicWebSocket
=== RUN   TestAccAWSAPIGatewayV2Stage_basicHttp
=== PAUSE TestAccAWSAPIGatewayV2Stage_basicHttp
=== RUN   TestAccAWSAPIGatewayV2Stage_defaultHttpStage
=== PAUSE TestAccAWSAPIGatewayV2Stage_defaultHttpStage
=== RUN   TestAccAWSAPIGatewayV2Stage_disappears
=== PAUSE TestAccAWSAPIGatewayV2Stage_disappears
=== RUN   TestAccAWSAPIGatewayV2Stage_AccessLogSettings
=== PAUSE TestAccAWSAPIGatewayV2Stage_AccessLogSettings
=== RUN   TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription
=== PAUSE TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription
=== RUN   TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsWebSocket
=== PAUSE TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsWebSocket
=== RUN   TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsHttp
=== PAUSE TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsHttp
=== RUN   TestAccAWSAPIGatewayV2Stage_Deployment
=== PAUSE TestAccAWSAPIGatewayV2Stage_Deployment
=== RUN   TestAccAWSAPIGatewayV2Stage_RouteSettingsWebSocket
=== PAUSE TestAccAWSAPIGatewayV2Stage_RouteSettingsWebSocket
=== RUN   TestAccAWSAPIGatewayV2Stage_RouteSettingsHttp
=== PAUSE TestAccAWSAPIGatewayV2Stage_RouteSettingsHttp
=== RUN   TestAccAWSAPIGatewayV2Stage_StageVariables
=== PAUSE TestAccAWSAPIGatewayV2Stage_StageVariables
=== RUN   TestAccAWSAPIGatewayV2Stage_Tags
=== PAUSE TestAccAWSAPIGatewayV2Stage_Tags
=== CONT  TestAccAWSAPIGatewayV2Stage_basicWebSocket
=== CONT  TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsHttp
=== CONT  TestAccAWSAPIGatewayV2Stage_Tags
=== CONT  TestAccAWSAPIGatewayV2Stage_StageVariables
=== CONT  TestAccAWSAPIGatewayV2Stage_RouteSettingsHttp
=== CONT  TestAccAWSAPIGatewayV2Stage_RouteSettingsWebSocket
=== CONT  TestAccAWSAPIGatewayV2Stage_Deployment
=== CONT  TestAccAWSAPIGatewayV2Stage_AccessLogSettings
=== CONT  TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsWebSocket
=== CONT  TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription
=== CONT  TestAccAWSAPIGatewayV2Stage_defaultHttpStage
=== CONT  TestAccAWSAPIGatewayV2Stage_disappears
=== CONT  TestAccAWSAPIGatewayV2Stage_basicHttp
--- PASS: TestAccAWSAPIGatewayV2Stage_disappears (12.77s)
--- PASS: TestAccAWSAPIGatewayV2Stage_basicHttp (15.75s)
--- PASS: TestAccAWSAPIGatewayV2Stage_basicWebSocket (15.99s)
--- PASS: TestAccAWSAPIGatewayV2Stage_Deployment (19.15s)
--- PASS: TestAccAWSAPIGatewayV2Stage_defaultHttpStage (25.40s)
--- PASS: TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription (34.85s)
--- PASS: TestAccAWSAPIGatewayV2Stage_StageVariables (52.43s)
--- PASS: TestAccAWSAPIGatewayV2Stage_AccessLogSettings (54.68s)
--- PASS: TestAccAWSAPIGatewayV2Stage_Tags (55.09s)
--- PASS: TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsWebSocket (61.99s)
--- PASS: TestAccAWSAPIGatewayV2Stage_RouteSettingsHttp (64.04s)
--- PASS: TestAccAWSAPIGatewayV2Stage_RouteSettingsWebSocket (71.80s)
--- PASS: TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsHttp (87.28s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	90.736s

Verified Acceptance Tests (GovCloud)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Stage_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Stage_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2Stage_basicWebSocket
=== PAUSE TestAccAWSAPIGatewayV2Stage_basicWebSocket
=== RUN   TestAccAWSAPIGatewayV2Stage_basicHttp
=== PAUSE TestAccAWSAPIGatewayV2Stage_basicHttp
=== RUN   TestAccAWSAPIGatewayV2Stage_defaultHttpStage
=== PAUSE TestAccAWSAPIGatewayV2Stage_defaultHttpStage
=== RUN   TestAccAWSAPIGatewayV2Stage_disappears
=== PAUSE TestAccAWSAPIGatewayV2Stage_disappears
=== RUN   TestAccAWSAPIGatewayV2Stage_AccessLogSettings
=== PAUSE TestAccAWSAPIGatewayV2Stage_AccessLogSettings
=== RUN   TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription
=== PAUSE TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription
=== RUN   TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsWebSocket
=== PAUSE TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsWebSocket
=== RUN   TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsHttp
=== PAUSE TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsHttp
=== RUN   TestAccAWSAPIGatewayV2Stage_Deployment
=== PAUSE TestAccAWSAPIGatewayV2Stage_Deployment
=== RUN   TestAccAWSAPIGatewayV2Stage_RouteSettingsWebSocket
=== PAUSE TestAccAWSAPIGatewayV2Stage_RouteSettingsWebSocket
=== RUN   TestAccAWSAPIGatewayV2Stage_RouteSettingsHttp
=== PAUSE TestAccAWSAPIGatewayV2Stage_RouteSettingsHttp
=== RUN   TestAccAWSAPIGatewayV2Stage_StageVariables
=== PAUSE TestAccAWSAPIGatewayV2Stage_StageVariables
=== RUN   TestAccAWSAPIGatewayV2Stage_Tags
=== PAUSE TestAccAWSAPIGatewayV2Stage_Tags
=== CONT  TestAccAWSAPIGatewayV2Stage_basicWebSocket
=== CONT  TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsHttp
=== CONT  TestAccAWSAPIGatewayV2Stage_AccessLogSettings
=== CONT  TestAccAWSAPIGatewayV2Stage_Deployment
=== CONT  TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription
=== CONT  TestAccAWSAPIGatewayV2Stage_disappears
=== CONT  TestAccAWSAPIGatewayV2Stage_basicHttp
=== CONT  TestAccAWSAPIGatewayV2Stage_StageVariables
=== CONT  TestAccAWSAPIGatewayV2Stage_RouteSettingsHttp
=== CONT  TestAccAWSAPIGatewayV2Stage_RouteSettingsWebSocket
=== CONT  TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsWebSocket
=== CONT  TestAccAWSAPIGatewayV2Stage_defaultHttpStage
=== CONT  TestAccAWSAPIGatewayV2Stage_Tags
--- PASS: TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription (19.78s)
--- PASS: TestAccAWSAPIGatewayV2Stage_StageVariables (22.20s)
--- PASS: TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsHttp (25.37s)
--- PASS: TestAccAWSAPIGatewayV2Stage_disappears (38.12s)
--- PASS: TestAccAWSAPIGatewayV2Stage_basicHttp (40.88s)
--- PASS: TestAccAWSAPIGatewayV2Stage_basicWebSocket (40.89s)
--- PASS: TestAccAWSAPIGatewayV2Stage_Deployment (44.25s)
--- PASS: TestAccAWSAPIGatewayV2Stage_Tags (44.86s)
--- PASS: TestAccAWSAPIGatewayV2Stage_AccessLogSettings (46.62s)
--- PASS: TestAccAWSAPIGatewayV2Stage_defaultHttpStage (47.80s)
--- PASS: TestAccAWSAPIGatewayV2Stage_RouteSettingsHttp (51.29s)
--- PASS: TestAccAWSAPIGatewayV2Stage_RouteSettingsWebSocket (59.57s)
--- PASS: TestAccAWSAPIGatewayV2Stage_DefaultRouteSettingsWebSocket (68.49s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	70.786s

@breathingdust breathingdust added this to the v3.0.0 milestone Jul 24, 2020
@breathingdust breathingdust merged commit e8bd28e into hashicorp:master Jul 24, 2020
breathingdust added a commit that referenced this pull request Jul 24, 2020
@breathingdust
Update CHANGELOG.md for #13809
3448292
@ewbankkit ewbankkit deleted the b-aws_apigatewayv2_stage-http-route-settings branch July 24, 2020 11:01
anGie44 pushed a commit that referenced this pull request Jul 27, 2020
@bflad @anGie44
parent b69af05
ee459d6 
author Brian Flad <[email protected]> 1594769808 -0400
committer Angie Pinilla <[email protected]> 1595878294 -0400

parent b69af0579e0415631faa9b77559a55a5f6e7c208
author Brian Flad <[email protected]> 1594769808 -0400
committer Angie Pinilla <[email protected]> 1595878093 -0400

tests/provider: Update testacc target to error when provided example test pattern (#14091)

* tests/provider: Update testacc target to error when provided example test pattern

Reference: https://github.com/terraform-providers/terraform-provider-aws/blob/master/.github/PULL_REQUEST_TEMPLATE.md

The pull request template suggests an example of how to run acceptance testing, but uses a placeholder example since its not feasible to reliably determine this automatically via git, etc. Also given that we have begun adding many more Go packages beyond just the top level provider one, the output can look potentially valid when it really is not meaningful:

```console
$ $ make testacc TESTARGS='-run=TestAccXXX'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccXXX -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2.594s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap	0.409s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags	0.792s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/naming	1.619s [no tests to run]
?   	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/apigatewayv2/waiter	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/batch/equivalency	0.373s [no tests to run]
?   	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/ec2/waiter	[no test files]
?   	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/ecs/waiter	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/eks/token	0.343s [no tests to run]
?   	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/guardduty/waiter	[no test files]
?   	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/iam/waiter	[no test files]
?   	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/kinesisanalytics/waiter	[no test files]
?   	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/kms/waiter	[no test files]
?   	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/neptune/waiter	[no test files]
?   	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/rds/waiter	[no test files]
?   	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/secretsmanager/waiter	[no test files]
?   	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/servicediscovery/waiter	[no test files]
?   	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/sfn/waiter	[no test files]
?   	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/workspaces/waiter	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/tfawsresource	1.022s [no tests to run]
?   	github.com/terraform-providers/terraform-provider-aws/awsproviderlint	[no test files]
?   	github.com/terraform-providers/terraform-provider-aws/awsproviderlint/helper/awsprovidertype/keyvaluetags	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes	2.115s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes/AWSAT001	2.212s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes/AWSAT002	0.326s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes/AWSR001	0.412s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes/AWSR002	2.086s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes/fmtsprintfcallexpr	0.248s [no tests to run]
```

This now focuses the acceptance testing on the top level package to remove the extraneous package output and returns an error when attempting to use the example verbatim:

```console
$ make testacc TESTARGS='-run=TestAccXXX'
==> Checking that code complies with gofmt requirements...

Error: Skipping example acceptance testing pattern. Update TESTARGS to match the test naming in the relevant *_test.go file.

For example if updating aws/resource_aws_acm_certificate.go, use the test names in aws/resource_aws_acm_certificate_test.go starting with TestAcc and up to the underscore:
make testacc TESTARGS='-run=TestAccAWSAcmCertificate_'

See the contributing guide for more information: https://github.com/terraform-providers/terraform-provider-aws/blob/master/docs/contributing/running-and-writing-acceptance-tests.md
make: *** [testacc] Error 1

$ make testacc TESTARGS='-run=TestAccAWSAvailabilityZones_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAvailabilityZones_ -timeout 120m
=== RUN   TestAccAWSAvailabilityZones_basic
...
```

* docs/provider: Remove TEST=./aws usage in running acceptance testing section

resource/aws_s3_bucket: Convert region to read-only attribute (#14127)

Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/592
Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/1656

Output from acceptance testing (NOTE: CUR data source and resource need to be tested in standalone account due to Organization permissions and appear to be failing due to new validation in the API that's not handled in the resource yet):

```
--- PASS: TestAccAWSS3Bucket_acceleration (65.86s)
--- PASS: TestAccAWSS3Bucket_AclToGrant (67.94s)
--- PASS: TestAccAWSS3Bucket_basic (37.25s)
--- PASS: TestAccAWSS3Bucket_Bucket_EmptyString (35.95s)
--- PASS: TestAccAWSS3Bucket_Cors_Delete (31.78s)
--- PASS: TestAccAWSS3Bucket_Cors_EmptyOrigin (37.29s)
--- PASS: TestAccAWSS3Bucket_Cors_Update (65.22s)
--- PASS: TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled (62.31s)
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed (37.28s)
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical (43.14s)
--- PASS: TestAccAWSS3Bucket_forceDestroy (31.61s)
--- PASS: TestAccAWSS3Bucket_forceDestroyWithEmptyPrefixes (31.54s)
--- PASS: TestAccAWSS3Bucket_forceDestroyWithObjectLockEnabled (37.95s)
--- PASS: TestAccAWSS3Bucket_generatedName (35.53s)
--- PASS: TestAccAWSS3Bucket_GrantToAcl (57.50s)
--- PASS: TestAccAWSS3Bucket_LifecycleBasic (86.93s)
--- PASS: TestAccAWSS3Bucket_LifecycleExpireMarkerOnly (62.03s)
--- PASS: TestAccAWSS3Bucket_LifecycleRule_Expiration_EmptyConfigurationBlock (31.01s)
--- PASS: TestAccAWSS3Bucket_Logging (55.35s)
--- PASS: TestAccAWSS3Bucket_namePrefix (35.81s)
--- PASS: TestAccAWSS3Bucket_objectLock (60.93s)
--- PASS: TestAccAWSS3Bucket_Policy (88.67s)
--- PASS: TestAccAWSS3Bucket_Replication (147.39s)
--- PASS: TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AccessControlTranslation (86.62s)
--- PASS: TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AddAccessControlTranslation (84.62s)
--- PASS: TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError (28.14s)
--- PASS: TestAccAWSS3Bucket_ReplicationSchemaV2 (152.22s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutPrefix (52.74s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutStorageClass (51.40s)
--- PASS: TestAccAWSS3Bucket_RequestPayer (63.26s)
--- PASS: TestAccAWSS3Bucket_shouldFailNotFound (15.41s)
--- PASS: TestAccAWSS3Bucket_tagsWithNoSystemTags (118.49s)
--- PASS: TestAccAWSS3Bucket_tagsWithSystemTags (163.94s)
--- PASS: TestAccAWSS3Bucket_UpdateAcl (58.70s)
--- PASS: TestAccAWSS3Bucket_UpdateGrant (91.75s)
--- PASS: TestAccAWSS3Bucket_Versioning (90.14s)
--- PASS: TestAccAWSS3Bucket_Website_Simple (89.22s)
--- PASS: TestAccAWSS3Bucket_WebsiteRedirect (86.48s)
--- PASS: TestAccAWSS3Bucket_WebsiteRoutingRules (63.97s)

--- PASS: TestAccAWSSsmResourceDataSync_basic (15.77s)
--- PASS: TestAccAWSSsmResourceDataSync_update (28.49s)

    TestAccAwsCurReportDefinition_basic: testing.go:684: Step 0 error: errors during apply:

        Error: Error creating AWS Cost And Usage Report Definition: ValidationException: Failed to verify customer bucket permission. accountId= --OMITTED--, bucket name: tf-test-bucket-3532084976228094739, bucket region: us-east-1

    TestAccDataSourceAwsCurReportDefinition_basic: testing.go:684: Step 0 error: errors during apply:

        Error: Error creating AWS Cost And Usage Report Definition: ValidationException: Failed to verify customer bucket permission. accountId= --OMITTED--, bucket name: tf-test-bucket-9147728765044904331, bucket region: us-east-1
```

Update CHANGELOG for #14127

Corrects name of Workspaces Workspace sweeper

let subject_alternative_names be a set

re-add computed: true to subject_alternative_names attribute

resource/aws_acm_certificate: Finalize subject_alternative_names change from TypeList to TypeSet

Reference: https://github.com/terraform-providers/terraform-provider-aws/pull/11300

Output from acceptance testing:

```
--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (11.98s)
--- PASS: TestAccAWSAcmCertificate_wildcard (14.66s)
--- PASS: TestAccAWSAcmCertificate_emailValidation (14.79s)
--- PASS: TestAccAWSAcmCertificate_root (15.12s)
--- PASS: TestAccAWSAcmCertificate_disableCTLogging (15.15s)
--- PASS: TestAccAWSAcmCertificate_san_TrailingPeriod (15.80s)
--- PASS: TestAccAWSAcmCertificate_wildcardAndRootSan (16.01s)
--- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (16.44s)
--- PASS: TestAccAWSAcmCertificate_rootAndWildcardSan (18.30s)
--- PASS: TestAccAWSAcmCertificate_san_single (18.38s)
--- PASS: TestAccAWSAcmCertificate_dnsValidation (18.62s)
--- PASS: TestAccAWSAcmCertificate_san_multiple (19.06s)
--- PASS: TestAccAWSAcmCertificate_privateCert (22.34s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (26.46s)
--- PASS: TestAccAWSAcmCertificate_tags (37.20s)
```

Remove hardcoded AMI IDs from launch_config data source

Removing import of aws_security_group_rule for rules associated with aws_security_group implicitly during its import. Acceptance tests updated to account for removed rules in import state check.

rebased and addressed review feedback

Update CHANGELOG for #12616

update documentation attributes

add missing validation value for comparison_operator argument

delete_on_termination on ENI has to be optional

like the EBS delete_on_termination this can be optional and cannot
be treated like a real bool but has to be treated as a string which
can be empty or a bool representation

testing all possible inputs

now testing as well `delete_on_termination = ""` and
`delete_on_termination = null` which both should not set the value to
anything.

adding upgrade instructions

version 3 upgrade details

Update CHANGELOG for #8612

add private_ips field

change private_ips to secondary_private_ips and enable update

update to using expandstringset method

Update CHANGELOG for #14079

Removed hardcoded AMI IDs from AutoscalingAttachment

docs/resource/aws_codebuild_webhook: Add COMMIT_MESSAGE to acceptable codebuild filter types (#14207)

Co-authored-by: mikiya771 <norep>

Fixes aws_lambda_alias import to set function_name attribute correctly instead of function's ARN

resource/aws_lambda_alias: Finalize resource import adjustments

Reference: https://github.com/terraform-providers/terraform-provider-aws/pull/12876

Output from acceptance testing:

```
--- PASS: TestAccAWSLambdaAlias_FunctionName_Name (35.53s)
--- PASS: TestAccAWSLambdaAlias_basic (53.18s)
--- PASS: TestAccAWSLambdaAlias_nameupdate (62.70s)
--- PASS: TestAccAWSLambdaAlias_routingconfig (63.82s)
```

Update CHANGELOG for #12876

remove trailing period from domainname/name attributes

update to using TrimSuffix strings method

isolate changes to only route53_zone

return error for singular data source

Error when data.aws_ecr_repository cannot find repository

Fixes https://github.com/terraform-providers/terraform-provider-aws/issues/10071.

adjust error messaging

return error for singular data source

add angie and dirk

consolidate maintainer lists

Ignore hardcoded AMI because not actually used

Add underscore to acceptance test names, minor naming convention fixes

provider: Remove unnecessary fmt.Sprint()/fmt.Sprintf() (#14242)

Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/14239

Update Terraform github to v2.9.2 (#14021)

* Update Terraform github to v2.9.2

* infrastructure/repository: Use organization argument instead of owner in github provider configuration

Appears that the provider reverted the deprecation of the `organization` argument and inclusion of the new `owner` argument in 2.9.x, delaying until 3.0.0.

Previously:

```
Error: Unsupported argument

  on main.tf line 14, in provider "github":
  14:   owner = "terraform-providers"

An argument named "owner" is not expected here.
```

Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Brian Flad <[email protected]>

add-q3-roadmap-draft

add old roadmap section

fix milestone link

remove currently in progress in case it causes confusion

r/aws_apigatewayv2_integration: suppress diff for passthrough_behavior

Update CHANGELOG for #13062

Update ROADMAP.md to fix formatting omissions

docs/provider: Setup and document release/* branch convention, link 2.x and earlier changelog entries (#14177)

* docs/provider: Setup and document release/* branch convention, link 2.x and earlier changelog entries

Reference: https://github.com/terraform-providers/terraform-provider-aws/tree/release/2.x

* tests/provider: Ensure release/* branches are ran on push via GitHub Actions

docs/provider: Document max_retries default (#14256)

adjust error formatting and handling

tests/resource/aws_s3_bucket: Add S3 Same-Region Replication acceptance test (#10170)

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSS3Bucket_SameRegionReplicationSchemaV2 (52.57s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAWSS3Bucket_SameRegionReplicationSchemaV2 (56.62s)
```

tests/resource/aws_rds_cluster: Remove aws_s3_bucket region argument from TestAccAWSRDSCluster_s3Restore (#14272)

Reference: https://github.com/terraform-providers/terraform-provider-aws/pull/14127

Missed during test configuration cleanup after the referenced argument removal. Fixes the initial configuration issue, but does not fix the (still) broken test which is presumably something to do with the backup file or engine version.

Previously:

```
--- FAIL: TestAccAWSRDSCluster_s3Restore (0.99s)
testing.go:684: Step 0 error: config is invalid: "region": this field cannot be set
```

Output from acceptance testing:

```
=== CONT  TestAccAWSRDSCluster_s3Restore
    TestAccAWSRDSCluster_s3Restore: testing.go:684: Step 0 error: errors during apply:

        Error: Error waiting for RDS Cluster state to be "available": unexpected state 'migration-failed', wanted target 'available'. last error: %!s(<nil>)
```

refactor resource import

set virtual attributes in import func

Update CHANGELOG for #10520 and #10521

update default value for min_capacity in scaling_configuration block of rds_cluster

Update CHANGELOG for #14268

keep throttling disabled by default in api gateway method settings resource

update import ID pattern

Update CHANGELOG for #14266

add plan time validation to `self_managed_active_directory.dns_ips`

add support for multi az deployment

add deployment type to test

add computed flag to deployment_type

add docs

fix docs

remove computed

fix multi az test

disappears

fix lint issue

add support for `SINGLE_AZ_2` type

Update website/docs/r/fsx_windows_file_system.html.markdown

Co-authored-by: Simon Davis <[email protected]>

Update website/docs/r/fsx_windows_file_system.html.markdown

Co-authored-by: Simon Davis <[email protected]>

Update website/docs/r/fsx_windows_file_system.html.markdown

Co-authored-by: Simon Davis <[email protected]>

Update CHANGELOG.md for #12676

Fix schema set errors (#14167)

* Fix schema set errors

* Fix wrong attribute

* Fix type

* Flatten ssm parameters

* resource/elasticsearch_domain: update method to set advanced_security_options  (#14198)

* set advanced security options only if enabled

* refactor and set values depending on enabled field

Co-authored-by: angie pinilla <[email protected]>

tests/provider: Enable AWSAT004 check for CI (#14216)

Reference: https://github.com/terraform-providers/terraform-provider-aws/pull/14097

resource/aws_launch_configuration: Remove DescribeLaunchConfigurations retries on all errors (#14260)

Reference: https://github.com/hashicorp/terraform/issues/302
Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13409

Does not seem to be occurring anymore, but could require additional load to manifest. Can re-add explicit retries as necessary.

Output from acceptance testing:

```
--- PASS: TestAccAWSLaunchConfiguration_withSpotPrice (11.31s)
--- PASS: TestAccAWSLaunchConfiguration_ebs_noDevice (13.17s)
--- PASS: TestAccAWSLaunchConfiguration_withBlockDevices (13.44s)
--- PASS: TestAccAWSLaunchConfiguration_withInstanceStoreAMI (13.67s)
--- PASS: TestAccAWSLaunchConfiguration_withEncryption (14.02s)
--- PASS: TestAccAWSLaunchConfiguration_basic (22.34s)
--- PASS: TestAccAWSLaunchConfiguration_withIAMProfile (24.19s)
--- PASS: TestAccAWSLaunchConfiguration_encryptedRootBlockDevice (25.59s)
--- PASS: TestAccAWSLaunchConfiguration_userData (28.60s)
--- PASS: TestAccAWSLaunchConfiguration_RootBlockDevice_VolumeSize (28.91s)
--- PASS: TestAccAWSLaunchConfiguration_updateEbsBlockDevices (30.96s)
--- PASS: TestAccAWSLaunchConfiguration_withVpcClassicLink (32.72s)
--- PASS: TestAccAWSLaunchConfiguration_RootBlockDevice_AmiDisappears (353.93s)
```

resource/aws_spot_fleet_request: Only retry RequestSpotFleet on IAM eventual consistency errors, use standard 2 minute timeout (#14265)

Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/7740
Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13409

Output from acceptance testing:

```
--- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (251.97s)
--- PASS: TestAccAWSSpotFleetRequest_basic (314.23s)
--- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (612.33s)
--- PASS: TestAccAWSSpotFleetRequest_disappears (261.47s)
--- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (403.92s)
--- PASS: TestAccAWSSpotFleetRequest_fleetType (316.94s)
--- PASS: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (251.69s)
--- PASS: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (253.29s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (112.90s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (142.33s)
--- PASS: TestAccAWSSpotFleetRequest_launchSpecToLaunchTemplate (467.97s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate (253.11s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate_multiple (254.84s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateToLaunchSpec (468.45s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateWithOverrides (253.43s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList (274.51s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (314.01s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (276.90s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (486.46s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (406.36s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (231.26s)
--- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (295.29s)
--- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (57.48s)
--- PASS: TestAccAWSSpotFleetRequest_tags (342.55s)
--- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (597.13s)
--- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (753.34s)
--- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (255.16s)
--- PASS: TestAccAWSSpotFleetRequest_WithELBs (277.96s)
--- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (232.56s)
--- PASS: TestAccAWSSpotFleetRequest_withTags (282.39s)
--- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (427.61s)
--- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (335.33s)
```

Update CHANGELOG for #14265

resource/aws_codepipeline: Only retry CreatePipeline errors for IAM eventual consistency (#14264)

Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13409

Output from acceptance testing:

```
--- PASS: TestAccAWSCodePipeline_emptyStageArtifacts (33.11s)
--- PASS: TestAccAWSCodePipeline_WithNamespace (35.13s)
--- PASS: TestAccAWSCodePipeline_multiregion_basic (36.83s)
--- PASS: TestAccAWSCodePipeline_deployWithServiceRole (42.85s)
--- PASS: TestAccAWSCodePipeline_basic (57.83s)
--- PASS: TestAccAWSCodePipeline_multiregion_Update (61.32s)
--- PASS: TestAccAWSCodePipeline_tags (76.28s)
--- PASS: TestAccAWSCodePipeline_multiregion_ConvertSingleRegion (79.20s)
```

Update CHANGELOG for #14264

resource/aws_ssm_activation: Only retry CreateActivation on IAM eventual consistency error, allow retries for standard 2 minutes (#14263)

Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13409

API does not seem to validate IAM Role permissions on creation.

Output from acceptance testing:

```
--- PASS: TestAccAWSSSMActivation_expirationDate (19.17s)
--- PASS: TestAccAWSSSMActivation_disappears (25.22s)
--- PASS: TestAccAWSSSMActivation_basic (27.39s)
--- PASS: TestAccAWSSSMActivation_update (37.23s)
```

Update CHANGELOG for #14263

resource/aws_network_acl_rule: Immediately return DescribeNetworkAcls errors on creation (#14261)

Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13409

Output from acceptance testing:

```
--- PASS: TestAccAWSNetworkAclRule_allProtocol (44.33s)
--- PASS: TestAccAWSNetworkAclRule_basic (32.50s)
--- PASS: TestAccAWSNetworkAclRule_disappears (32.83s)
--- PASS: TestAccAWSNetworkAclRule_disappears_NetworkAcl (27.16s)
--- PASS: TestAccAWSNetworkAclRule_ingressEgressSameNumberDisappears (30.24s)
--- PASS: TestAccAWSNetworkAclRule_ipv6 (29.23s)
--- PASS: TestAccAWSNetworkAclRule_ipv6ICMP (28.65s)
--- PASS: TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate (47.71s)
--- PASS: TestAccAWSNetworkAclRule_missingParam (15.14s)
--- PASS: TestAccAWSNetworkAclRule_tcpProtocol (40.32s)
```

Update CHANGELOG for #14261

Add function to check TypeSet pairs

Add unit tests for TestCheckTypeSetElemAttrPair

tests/resource/aws_rds_cluster: Fix TestAccAWSRDSCluster_EngineVersion (#14286)

isolate changes to only route53_record resource

update additional domian name example in upgrade guide

Co-authored-by: Brian Flad <[email protected]>

update with CR comments

isolate changes to only resolver rule

isolate changes to only acm_certificate

isolate changes to only ses_domain_identity

re-add trailing period acctest

merge with parent branch and update statefuncs to use global method

update statefuncs to use global method and update tests w/trailingp period domains

r/aws_apigatewayv2_stage: Make deployment_id a computed attribute.

Update CHANGELOG.md for #13644

bump to go v1.14.5

r/aws_apigatewayv2_integration: Add 'request_parameters' attribute.

Update CHANGELOG.md for #14080

r/aws_apigatewayv2_route: Update route key.

Update CHANGELOG.md for #13833

Revert "Remove 'tls_config' attribute. It doesn't seem to do anything right now."

This reverts commit ffbce32f931a9b33adc8407a267ba176c510bd44.

r/aws_apigatewayv2_integration: Test HTTP API VPC Link integration.

r/aws_apigatewayv2_integration: Additional import test step in 'TestAccAWSAPIGatewayV2Integration_VpcLinkHttp'.

Update CHANGELOG.md

Update CHANGELOG.md for #13013

Update CHANGELOG.md

add atleastoneof property to filter attributes

Update CHANGELOG for #14230

Remove hardcoded AMI and AZ

Improve static check for hardcoded partition in ARN

resource/aws_lambda_function: Increase IAM retry timeout for create to 2 minutes (#14291)

References:
* https://github.com/terraform-providers/terraform-provider-aws/issues/14285

Increased the retry timeout for eventual consistency IAM errors during a
lambda function create from 1 minute to 2 minute.

Output from acceptance testing:

```
make testacc TEST=./aws TESTARGS='-run=TestAccAWSLambdaFunction_'
...
--- PASS: TestAccAWSLambdaFunction_basic (28.86s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_java8 (34.46s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (160.32s)
--- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (208.54s)
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (567.54s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (596.13s)
--- PASS: TestAccAWSLambdaFunction_LayersUpdate (49.02s)
--- PASS: TestAccAWSLambdaFunction_VPC (362.84s)
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (797.25s)
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (120.01s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (51.30s)
--- PASS: TestAccAWSLambdaFunction_envVariables (153.15s)
--- PASS: TestAccAWSLambdaFunction_versioned (39.16s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (61.80s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python37 (31.16s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (51.77s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_dotnetcore31 (36.20s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_ruby27 (40.86s)
--- PASS: TestAccAWSLambdaFunction_Layers (38.54s)
--- PASS: TestAccAWSLambdaFunction_tracingConfig (51.87s)
--- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (36.57s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (54.03s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_ruby25 (36.53s)
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (13.34s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python38 (28.27s)
--- PASS: TestAccAWSLambdaFunction_tags (51.19s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_java11 (36.59s)
--- PASS: TestAccAWSLambdaFunction_updateRuntime (51.42s)
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (43.77s)
--- PASS: TestAccAWSLambdaFunction_localUpdate (39.80s)
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (44.15s)
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (40.02s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python36 (32.09s)
--- PASS: TestAccAWSLambdaFunction_FileSystemConfig (721.87s)
--- PASS: TestAccAWSLambdaFunction_s3 (31.68s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_provided (36.48s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python27 (33.63s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_NodeJs10x (38.17s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_noRuntime (0.91s)
--- PASS: TestAccAWSLambdaFunction_concurrency (46.63s)
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (38.38s)
--- PASS: TestAccAWSLambdaFunction_disappears (36.13s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_NodeJs12x (38.47s)
```

Update CHANGELOG for #14291

error when iops provided for unsupported type

improve upgrade docs for iops

Update CHANGELOG for #14310

Update CHANGELOG with Go versioning

Remove hardcoded AMIs and AZs

Remove hardcoded AMIs and AZs

Removed hardcoded AMIs and AZs

Remove hardcoded AMI and AZ

Remove hardcoded AMI

r/aws_apigatewayv2_stage: 'data_trace_enabled' and 'logging_level' are only valid for WebSocket APIs.

r/aws_apigatewayv2_stage: No need for diff-suppression for new resources.

r/aws_apigatewayv2_stage: Additional route_settings and default_route_settings test cases.

r/aws_apigatewayv2_stage: Add computed 'api_protocol_type' attribute.

r/aws_apigatewayv2_stage: Pass API protocol type to 'flattenApiGatewayV2RouteSettings'.

Revert "r/aws_apigatewayv2_stage: Pass API protocol type to 'flattenApiGatewayV2RouteSettings'."

This reverts commit 9337272b7842879cdbae5be19ec076bea314b20c.

Revert "r/aws_apigatewayv2_stage: Add computed 'api_protocol_type' attribute."

This reverts commit a7eb7cf9976ecabb04696dbe2f39805cc0ec1401.

Fix mess from rebase.

r/aws_apigatewayv2_stage: Change 'route_setting.logging_level' to computed to address different defaults for WebSocket vs. HTTP.

Update CHANGELOG.md for #13809

resource/aws_acm_certificate: Convert domain_validation_options to TypeSet and calculate elements during plan (#14199)

* resource/aws_acm_certificate: Convert domain_validation_options to TypeSet and calculate elements during plan

Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/8531
Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/10098
Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/10404
Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13053

Output from acceptance testing:

```
--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (11.48s)
--- PASS: TestAccAWSAcmCertificate_rootAndWildcardSan (15.53s)
--- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (15.53s)
--- PASS: TestAccAWSAcmCertificate_root (15.62s)
--- PASS: TestAccAWSAcmCertificate_emailValidation (15.91s)
--- PASS: TestAccAWSAcmCertificate_san_TrailingPeriod (16.38s)
--- PASS: TestAccAWSAcmCertificate_wildcardAndRootSan (16.43s)
--- PASS: TestAccAWSAcmCertificate_san_single (16.51s)
--- PASS: TestAccAWSAcmCertificate_dnsValidation (16.85s)
--- PASS: TestAccAWSAcmCertificate_disableCTLogging (17.06s)
--- PASS: TestAccAWSAcmCertificate_wildcard (18.71s)
--- PASS: TestAccAWSAcmCertificate_san_multiple (19.49s)
--- PASS: TestAccAWSAcmCertificate_privateCert (20.85s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (26.86s)
--- PASS: TestAccAWSAcmCertificate_tags (42.99s)

--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsEmail (11.56s)
--- PASS: TestAccAWSAcmCertificateValidation_timeout (19.20s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdns (107.31s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsSan (110.62s)
--- PASS: TestAccAWSAcmCertificateValidation_basic (143.58s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcardAndRoot (153.05s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsRoot (212.21s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsRootAndWildcard (212.95s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcard (247.43s)
```

Please note that this was also tested manually with a few iterations of this configuration:

```hcl
terraform {
    required_providers {
        aws = "2.70.0"
    }
    required_version = "0.12.28"
}

provider "aws" {
  region = "us-east-2"
}

variable "public_root_domain" {
  description = "Publicly accessible domain for ACM testing"
  type        = string
}

data "aws_route53_zone" "public_root_domain" {
  name = var.public_root_domain
}

resource "aws_acm_certificate" "new" {
  domain_name               = "new.${var.public_root_domain}"
  subject_alternative_names = [
    "new1.${var.public_root_domain}",
    "new2.${var.public_root_domain}",
    "new3.${var.public_root_domain}",
  ]
  validation_method         = "DNS"
}

resource "aws_route53_record" "new" {
  for_each = {
    for dvo in aws_acm_certificate.new.domain_validation_options: dvo.domain_name => {
      name   = dvo.resource_record_name
      record = dvo.resource_record_value
      type   = dvo.resource_record_type
    }
  }

  allow_overwrite = true
  name            = each.value.name
  records         = [each.value.record]
  ttl             = 60
  type            = each.value.type
  zone_id         = data.aws_route53_zone.public_root_domain.zone_id
}

resource "aws_acm_certificate_validation" "new" {
  certificate_arn         = aws_acm_certificate.new.arn
  validation_record_fqdns = [for record in aws_route53_record.new: record.fqdn]
}

resource "aws_acm_certificate" "wildcard" {
  domain_name               = var.public_root_domain
  subject_alternative_names = ["*.${var.public_root_domain}"]
  validation_method         = "DNS"
}

resource "aws_route53_record" "wildcard" {
  for_each = {
    for dvo in aws_acm_certificate.wildcard.domain_validation_options: dvo.domain_name => {
      name   = dvo.resource_record_name
      record = dvo.resource_record_value
      type   = dvo.resource_record_type
    }
  }

  allow_overwrite = true
  name            = each.value.name
  records         = [each.value.record]
  ttl             = 60
  type            = each.value.type
  zone_id         = data.aws_route53_zone.public_root_domain.zone_id
}

resource "aws_acm_certificate_validation" "wildcard" {
  certificate_arn         = aws_acm_certificate.wildcard.arn
  validation_record_fqdns = [for record in aws_route53_record.wildcard: record.fqdn]
}
```

* docs/service/acm: Fix terrafmt reports

Previously:

```
website/docs/r/acm_certificate.html.markdown:83
website/docs/r/acm_certificate_validation.html.markdown:25
website/docs/r/acm_certificate_validation.html.markdown:67
```

Update CHANGELOG for #14199

Implement Disappears test for API Gateway resources (#13243)

* add disappears test case for APIGW API Key

* add disappears test case for APIGW Authorizer

* add disappears test case for APIGW Base Path

* add disappears test case for APIGW Client Cert

* add disappears test case for APIGW Deployment

* add disappears test case for APIGW Doc Part

* add disappears test case for APIGW Doc Ver

* add disappears test case for APIGW Domain Name

* add disappears test case for APIGW Gateway Response

* add disappears test case for APIGW Integration Response

* add disappears test case for APIGW Integration

* add disappears test case for APIGW Method

* add disappears test case for APIGW Method Response

* add disappears test case for APIGW Method Settings

* add disappears test case for APIGW Model

* add disappears test case for APIGW Request Validator

* add disappears test case for APIGW Resource

* add disappears test case for APIGW Rest API

* add disappears test case for APIGW Stage

* add disappears test case for APIGW Usage Plan Key

* add disappears test case for APIGW Usage Plan

* add disappears test case for APIGW VPC Link

* fix

* fix lint

docs/resource/aws_codebuild_project: Add SECRETS_MANAGER to the CodeBuild environment_variable type (#14200)

Updates alexa example

Updates api-gateway-websocket-chat-app example

Updates asg example

Updates cloudhsm example

Updates cloudwatch-events kinesis and sns examples

Updates cognito-user-pool example

Updates count example

Updates dx-gateway-cross-account-vgw-association example

Updates ecs-alb example

Updates eip example

Updates eks-getting-started example

Updates elasticsearch-domain example

Updates elb example

Updates lambda example

Updates lambda-file-system example

Updates networking example

Updates rds example

Updates s3-api-gateway-integration example

Updates s3-cross-account-access

Updates sagemaker example

Updates transit-gateway-cross-account-peering-attachment example

Updates transit-gateway-cross-account-vpc-attachment example

Updates two-tier example

Updates workspaces example

Updates example action workflow to validate only with Terraform 0.12. Adds error for testing

Restore `terraform validate` output

Only check for warnings if there are no errors

Fixes bash conditional

Wraps jq result in quotes to force it into a string to avoid "unary operator expected" error

Tightens warning check

Updates warning equality

Simplify warning check since it will exit on syntax errors

Resetting warning test to debug it

Add back terraform validate -json

Adds back jq

Echoes warning count

Step-by-step

Baby steps

One step back

Again

Try anything

Drops checks for warnings

Removes error added for testing

Got it!

resource/aws_ssm_maintenance_window_task: Remove deprecated logging_info and task_parameters configuration blocks (#14311)

Reference: https://github.com/terraform-providers/terraform-provider-aws/pull/7823
Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13398

Output from acceptance testing:

```
--- PASS: TestAccAWSSSMMaintenanceWindowTask_emptyNotificationConfig (13.56s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationStepFunctionParameters (14.66s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource (22.46s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_basic (22.75s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationLambdaParameters (36.30s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationAutomationParameters (36.56s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationRunCommandParameters (39.53s)
```

Update CHANGELOG for #14311

resource/aws_lb_listener_rule: Remove deprecated condition configuration block field and values arguments (#14309)

Reference: https://github.com/terraform-providers/terraform-provider-aws/pull/8268
Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13398

Already documented in the version 3 upgrade guide.

Output from acceptance testing:

```
--- PASS: TestAccAWSLBListenerRule_Action_Order (242.39s)
--- PASS: TestAccAWSLBListenerRule_Action_Order_Recreates (172.01s)
--- PASS: TestAccAWSLBListenerRule_BackwardsCompatibility (192.52s)
--- PASS: TestAccAWSLBListenerRule_basic (205.77s)
--- PASS: TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew (234.49s)
--- PASS: TestAccAWSLBListenerRule_cognito (190.75s)
--- PASS: TestAccAWSLBListenerRule_conditionAttributesCount (10.86s)
--- PASS: TestAccAWSLBListenerRule_conditionHostHeader (227.40s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpHeader (194.36s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpHeader_invalid (1.43s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpRequestMethod (195.55s)
--- PASS: TestAccAWSLBListenerRule_conditionMultiple (269.78s)
--- PASS: TestAccAWSLBListenerRule_conditionPathPattern (199.17s)
--- PASS: TestAccAWSLBListenerRule_conditionQueryString (195.57s)
--- PASS: TestAccAWSLBListenerRule_conditionSourceIp (186.73s)
--- PASS: TestAccAWSLBListenerRule_conditionUpdateMixed (274.24s)
--- PASS: TestAccAWSLBListenerRule_conditionUpdateMultiple (267.11s)
--- PASS: TestAccAWSLBListenerRule_fixedResponse (213.36s)
--- PASS: TestAccAWSLBListenerRule_forwardWeighted (213.62s)
--- PASS: TestAccAWSLBListenerRule_oidc (206.04s)
--- PASS: TestAccAWSLBListenerRule_priority (377.75s)
--- PASS: TestAccAWSLBListenerRule_redirect (248.43s)
--- PASS: TestAccAWSLBListenerRule_updateFixedResponse (189.01s)
--- PASS: TestAccAWSLBListenerRule_updateRulePriority (206.44s)
```

Update CHANGELOG for #14309

resource/aws_cognito_user_pool: Remove deprecated admin_create_user_config.unused_account_validity_days argument (#14294)

Reference: https://github.com/terraform-providers/terraform-provider-aws/pull/10890
Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13398

Output from acceptance testing:

```
--- PASS: TestAccAWSCognitoUserPool_basic (16.93s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfiguration (47.75s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationAndSoftwareTokenMfaConfiguration (50.45s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationToSoftwareTokenMfaConfiguration (46.37s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfiguration (41.83s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfigurationToSmsConfiguration (35.22s)
--- PASS: TestAccAWSCognitoUserPool_SmsAuthenticationMessage (36.72s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration (45.69s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration_ExternalId (43.87s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration_SnsCallerArn (41.27s)
--- PASS: TestAccAWSCognitoUserPool_SmsVerificationMessage (21.39s)
--- PASS: TestAccAWSCognitoUserPool_update (38.77s)
--- PASS: TestAccAWSCognitoUserPool_withAdminCreateUserConfiguration (26.14s)
--- PASS: TestAccAWSCognitoUserPool_withAdminCreateUserConfigurationAndPasswordPolicy (13.70s)
--- PASS: TestAccAWSCognitoUserPool_withAdvancedSecurityMode (32.33s)
--- PASS: TestAccAWSCognitoUserPool_withAliasAttributes (23.59s)
--- PASS: TestAccAWSCognitoUserPool_withDeviceConfiguration (21.89s)
--- PASS: TestAccAWSCognitoUserPool_withEmailVerificationMessage (21.15s)
--- PASS: TestAccAWSCognitoUserPool_withLambdaConfig (46.71s)
--- PASS: TestAccAWSCognitoUserPool_withPasswordPolicy (36.75s)
--- PASS: TestAccAWSCognitoUserPool_withSchemaAttributes (22.83s)
--- PASS: TestAccAWSCognitoUserPool_withTags (33.77s)
--- PASS: TestAccAWSCognitoUserPool_withUsernameConfiguration (28.12s)
--- PASS: TestAccAWSCognitoUserPool_withVerificationMessageTemplate (21.48s)
```

Update CHANGELOG for #14294

tests/provider: Ensure awsproviderlint source is dependency and lint checked (#14131)

* tests/provider: Ensure awsproviderlint source is dependency and lint checked

Reference: https://github.com/terraform-providers/terraform-provider-aws/pull/14129

* provider: Add awsproviderlint to make fmt target

provider: Initial snapshot build workflow (#14140)

Using GitHub Actions artifacts, sets up daily snapshot builds of master and allows other snapshot builds.

resource/aws_iam_access_key: Remove deprecated ses_smtp_password attribute (#14299)

Reference: https://github.com/terraform-providers/terraform-provider-aws/pull/11144
Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13398

Output from acceptance testing:

```
--- PASS: TestAccAWSAccessKey_basic (5.87s)
--- PASS: TestAccAWSAccessKey_encrypted (5.97s)
--- PASS: TestAccAWSAccessKey_inactive (9.72s)
```

Update CHANGELOG for #14299

provider: Remove deprecated kinesis_analytics and r53 custom endpoint arguments (#14238)

Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13398

Output from acceptance testing:

```
--- PASS: TestAccAWSProvider_Region_AwsCommercial (3.64s)
--- PASS: TestAccAWSProvider_Region_AwsChina (3.64s)
--- PASS: TestAccAWSProvider_Region_AwsGovCloudUs (3.65s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_Multiple (4.00s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_None (4.00s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_Multiple (4.01s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_One (4.01s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_None (4.01s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_One (4.02s)
--- PASS: TestAccAWSProvider_IgnoreTags_EmptyConfigurationBlock (4.01s)
--- PASS: TestAccAWSProvider_Endpoints (4.08s)
--- PASS: TestAccAWSProvider_AssumeRole_Empty (7.80s)
```

Update CHANGELOG for #14238

resource/aws_glue_job: Remove deprecated allocated_capacity argument (#14296)

Reference: https://github.com/terraform-providers/terraform-provider-aws/pull/7340
Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13398

Output from acceptance testing:

```
--- PASS: TestAccAWSGlueJob_basic (14.45s)
--- PASS: TestAccAWSGlueJob_Description (21.70s)
--- PASS: TestAccAWSGlueJob_GlueVersion (21.74s)
--- PASS: TestAccAWSGlueJob_MaxRetries (21.92s)
--- PASS: TestAccAWSGlueJob_Command (21.95s)
--- PASS: TestAccAWSGlueJob_DefaultArguments (22.08s)
--- PASS: TestAccAWSGlueJob_NotificationProperty (22.10s)
--- PASS: TestAccAWSGlueJob_Timeout (22.13s)
--- PASS: TestAccAWSGlueJob_ExecutionProperty (22.43s)
--- PASS: TestAccAWSGlueJob_MaxCapacity (22.43s)
--- PASS: TestAccAWSGlueJob_SecurityConfiguration (22.48s)
--- PASS: TestAccAWSGlueJob_WorkerType (29.22s)
--- PASS: TestAccAWSGlueJob_Tags (29.29s)
--- PASS: TestAccAWSGlueJob_PythonShell (30.12s)
```

Update CHANGELOG for #14296

resource/aws_iam_instance_profile: Remove deprecated roles argument (#14303)

Reference: https://github.com/hashicorp/terraform/pull/13130
Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13398

Output from acceptance testing:

```
--- PASS: TestAccAWSIAMInstanceProfile_withoutRole (6.44s)
--- PASS: TestAccAWSIAMInstanceProfile_basic (6.92s)
--- PASS: TestAccAWSIAMInstanceProfile_namePrefix (6.94s)

--- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (53.25s)

--- PASS: TestAccAWSAppautoScalingTarget_emrCluster (790.81s)

--- PASS: TestAccAWSBeanstalkEnv_tier (518.46s)

--- PASS: TestAccAWSIAMRole_testNameChange (12.80s)

--- PASS: TestAccAWSInstance_instanceProfileChange (204.32s)
--- PASS: TestAccAWSInstance_withIamInstanceProfile (115.26s)

--- PASS: TestAccAWSLaunchConfiguration_withIAMProfile (21.61s)
```

Update CHANGELOG for #14303

Remove hardcoded AMIs and AZs

resource/aws_sns_topic_subscription: Use paginated ListSubscriptionsByTopic and return immediately on errors (#14262)

* tests/resource/aws_sns_topic_subscription: Fix recurring and unrelated test configuration error

Previously:

```
--- FAIL: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (63.28s)
testing.go:684: Step 0 error: After applying this step, the plan was not empty:
DIFF:
UPDATE: aws_api_gateway_authorizer.test
...
authorizer_result_ttl_in_seconds: "300" => "0"
```

Output from acceptance testing:

```
--- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (91.18s)
```

* resource/aws_sns_topic_subscription: Use paginated ListSubscriptionsByTopic and return immediately on errors

Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13409

Output from acceptance testing:

```
--- PASS: TestAccAWSSNSTopicSubscription_basic (13.47s)
--- PASS: TestAccAWSSNSTopicSubscription_rawMessageDelivery (27.13s)
--- PASS: TestAccAWSSNSTopicSubscription_filterPolicy (28.12s)
--- PASS: TestAccAWSSNSTopicSubscription_deliveryPolicy (28.38s)
--- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (48.31s)
--- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (91.18s)
```

Update CHANGELOG for #14262

service/directconnect: vpn_gateway_id Argument Removals and Increase aws_dx_gateway_association Default Timeouts (#14144)

* resource/aws_dx_gateway_association: Increase default create/update/delete timeouts to 30 minutes

Previously, we were seeing consistent failures across many of acceptance tests:

```
    TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewaySingleAccount: testing.go:684: Step 1 error: errors during apply:

        Error: error waiting for Direct Connect gateway association (ga-a59d30b3-e6de-435e-bb17-cd7ed23f400evgw-06bccd6488d2b8d87) to become available: timeout while waiting for state to become 'associated' (last state: 'updating', timeout: 10m0s)

    TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewayCrossAccount: testing.go:684: Step 1 error: errors during apply:

        Error: error waiting for Direct Connect gateway association (ga-a8b1b976-c0a1-4b64-8560-9d9cc45d11a3vgw-0a2e52679acf9c250) to become available: timeout while waiting for state to become 'associated' (last state: 'updating', timeout: 10m0s)

--- FAIL: TestAccAwsDxGatewayAssociation_basicTransitGatewaySingleAccount (989.81s)
testing.go:684: Step 0 error: errors during apply:
Error: error waiting for Direct Connect gateway association (ga-48d0e3d3-e131-443d-9693-e64eff519baatgw-0a2a0ea77f65ed202) to become available: timeout while waiting for state to become 'associated' (last state: 'associating', timeout: 15m0s)

--- FAIL: TestAccAwsDxGatewayAssociation_basicTransitGatewayCrossAccount (991.80s)
testing.go:684: Step 0 error: errors during apply:
Error: error waiting for Direct Connect gateway association (ga-9f9c1ed2-97b6-41c5-8018-0724f6162b59tgw-06f7ce56df96282d7) to become available: timeout while waiting for state to become 'associated' (last state: 'associating', timeout: 15m0s)

--- FAIL: TestAccAwsDxGatewayAssociation_basicVpnGatewaySingleAccount (1816.92s)
testing.go:684: Step 0 error: errors during apply:
Error: error waiting for Direct Connect gateway association (ga-76c9d0f4-b0aa-4b1b-96d9-10ce8c3ca025vgw-0c47a2c63baf7d4d8) to become available: timeout while waiting for state to become 'associated' (last state: 'associating', timeout: 15m0s)

testing.go:745: Error destroying resource! WARNING: Dangling resources
may exist. The full state and error is shown below.
Error: errors during apply: error waiting for Direct Connect gateway association (ga-76c9d0f4-b0aa-4b1b-96d9-10ce8c3ca025vgw-0c47a2c63baf7d4d8) to be deleted: timeout while waiting for state to become 'disassociated, deleted' (last state: 'disassociating', timeout: 15m0s)

--- FAIL: TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewaySingleAccount (1816.89s)
testing.go:684: Step 0 error: errors during apply:
Error: error waiting for Direct Connect gateway association (ga-12a5c1e8-322e-4bc1-8a5a-f4b778a00db3vgw-09c811d121256131b) to become available: timeout while waiting for state to become 'associated' (last state: 'associating', timeout: 15m0s)

testing.go:745: Error destroying resource! WARNING: Dangling resources
may exist. The full state and error is shown below.
Error: errors during apply: error waiting for Direct Connect gateway association (ga-12a5c1e8-322e-4bc1-8a5a-f4b778a00db3vgw-09c811d121256131b) to be deleted: timeout while waiting for state to become 'disassociated, deleted' (last state: 'disassociating', timeout: 15m0s)

--- FAIL: TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewayCrossAccount (1819.25s)
testing.go:684: Step 0 error: errors during apply:
Error: error waiting for Direct Connect gateway association (ga-ccf678f2-5d51-441e-86c5-308c731f26abvgw-063e75f539bc3719c) to become available: timeout while waiting for state to become 'associated' (last state: 'associating', timeout: 15m0s)

testing.go:745: Error destroying resource! WARNING: Dangling resources
may exist. The full state and error is shown below.
Error: errors during apply: error waiting for Direct Connect gateway association (ga-ccf678f2-5d51-441e-86c5-308c731f26abvgw-063e75f539bc3719c) to be deleted: timeout while waiting for state to become 'disassociated, deleted' (last state: 'disassociating', timeout: 15m0s)

--- FAIL: TestAccAwsDxGatewayAssociation_multiVpnGatewaysSingleAccount (2487.01s)
testing.go:684: Step 0 error: errors during apply:
Error: error waiting for Direct Connect gateway association (ga-5d93ccd0-8344-4ee6-95f8-58af27e01301vgw-054e2b0e7ecf45c8d) to become available: timeout while waiting for state to become 'associated' (last state: 'associating', timeout: 15m0s)

Error: error waiting for Direct Connect gateway association (ga-5d93ccd0-8344-4ee6-95f8-58af27e01301vgw-057b39dbec7338ec1) to become available: timeout while waiting for state to become 'associated' (last state: 'associating', timeout: 15m0s)

testing.go:745: Error destroying resource! WARNING: Dangling resources
may exist. The full state and error is shown below.
Error: errors during apply: error waiting for Direct Connect gateway association (ga-5d93ccd0-8344-4ee6-95f8-58af27e01301vgw-057b39dbec7338ec1) to be deleted: timeout while waiting for state to become 'disassociated, deleted' (last state: 'disassociating', timeout: 15m0s)

--- FAIL: TestAccAwsDxGatewayAssociation_basicVpnGatewayCrossAccount (2529.42s)
testing.go:684: Step 0 error: errors during apply:
Error: error waiting for Direct Connect gateway association (ga-ad8143a9-657e-4ed2-9ebb-a78dd2bee2c1vgw-0d552249edec48941) to become available: timeout while waiting for state to become 'associated' (last state: 'associating', timeout: 15m0s)

testing.go:745: Error destroying resource! WARNING: Dangling resources
may exist. The full state and error is shown below.
Error: errors during apply: Error waiting for VPN Gateway "vgw-0d552249edec48941" to detach from VPC "vpc-0cbba5ddf6a4ec7ba": timeout while waiting for state to become 'detached' (last state: 'detaching', timeout: 15m0s)

--- FAIL: TestAccAwsDxGatewayAssociation_deprecatedSingleAccount (2551.41s)
testing.go:684: Step 0 error: errors during apply:
Error: error waiting for Direct Connect gateway association (ga-c1c37095-ab8d-4dcd-9f97-b369face1ad4vgw-0576f5ab3096ace51) to become available: timeout while waiting for state to become 'associated' (last state: 'associating', timeout: 15m0s)
```

* service/directconnect: Remove vpn_gateway_id arguments

Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13398

Changes:

```
* resource/aws_dx_gateway_association: Remove `vpn_gateway_id` argument
* resource/aws_dx_gateway_association_proposal: Remove `vpn_gateway_id` argument
```

Output from acceptance testing:

```
--- PASS: TestAccAwsDxGatewayAssociation_basicTransitGatewaySingleAccount (2063.56s)
--- PASS: TestAccAwsDxGatewayAssociation_basicTransitGatewayCrossAccount (2556.75s)
--- PASS: TestAccAwsDxGatewayAssociation_multiVpnGatewaysSingleAccount (2668.06s)
--- PASS: TestAccAwsDxGatewayAssociation_basicVpnGatewaySingleAccount (2674.09s)
--- PASS: TestAccAwsDxGatewayAssociation_basicVpnGatewayCrossAccount (2677.20s)
--- PASS: TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewaySingleAccount (3612.36s)
--- PASS: TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewayCrossAccount (3856.32s)

--- PASS: TestAccAwsDxGatewayAssociationProposal_basicVpnGateway (88.64s)
--- PASS: TestAccAwsDxGatewayAssociationProposal_disappears (96.50s)
--- PASS: TestAccAwsDxGatewayAssociationProposal_AllowedPrefixes (121.18s)
--- PASS: TestAccAwsDxGatewayAssociationProposal_basicTransitGateway (182.42s)
```

* tests/resource/aws_dx_gateway_association: Ensure v0 state upgrade is still covered by acceptance testing

Output from acceptance testing:

```
--- PASS: TestAccAwsDxGatewayAssociation_V0StateUpgrade (2605.48s)
```

Update CHANGELOG for #14144

docs/resource/aws_security_group: Update `cidr_blocks` value to list (#14329)

add support for zero ttl

add validation for `authorizer_uri`, `authorizer_credentials`
changes for %w
remove deprecated func

use set len func

revert validation for `authorizer_uri`

refactor tests

refactor tests

Update CHANGELOG for #12643

resource/aws_appautoscaling_target: Remove  DeregisterScalableTarget retries on all errors and add disappears test (#14259)

Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13409
Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13826

Output from acceptance testing:

```
--- PASS: TestAccAWSAppautoScalingTarget_multipleTargets (20.68s)
--- PASS: TestAccAWSAppautoScalingTarget_optionalRoleArn (25.17s)
--- PASS: TestAccAWSAppautoScalingTarget_basic (43.13s)
--- PASS: TestAccAWSAppautoScalingTarget_spotFleetRequest (57.42s)
--- PASS: TestAccAWSAppautoScalingTarget_disappears (71.79s)
--- PASS: TestAccAWSAppautoScalingTarget_emrCluster (840.33s)

--- PASS: TestAccAWSAppautoScalingPolicy_multiplePoliciesSameName (24.97s)
--- PASS: TestAccAWSAppautoScalingPolicy_dynamodb_table (26.58s)
--- PASS: TestAccAWSAppautoScalingPolicy_multiplePoliciesSameResource (28.13s)
--- PASS: TestAccAWSAppautoScalingPolicy_dynamodb_index (37.07s)
--- PASS: TestAccAWSAppautoScalingPolicy_spotFleetRequest (71.64s)
--- PASS: TestAccAWSAppautoScalingPolicy_disappears (75.45s)
--- PASS: TestAccAWSAppautoScalingPolicy_basic (77.30s)
--- PASS: TestAccAWSAppautoScalingPolicy_scaleOutAndIn (79.17s)
--- PASS: TestAccAWSAppautoScalingPolicy_ResourceId_ForceNew (83.72s)
```

Update CHANGELOG for #14259

update statefuncs to use global method

update statefuncs to use global method

Update provider's S3 bucket lookup to use GetBucketRegion utility (#14221)

* Update provider's S3 bucket lookup to use GetBucketRegion utility

Replaces the usage of S3's GetBucketLocation with the aws-sdk-go's
GetBucketRegion utility. This utility can discover the bucket's region
without authentication, and can be configured to be compatible with
FIPS endpoints.

Fixes https://github.com/terraform-providers/terraform-provider-aws/issues/14217
Related to https://github.com/aws/aws-sdk-go/issues/3115

* Add AWS SDK for Go s3manager dependency

Adds a dependency on the AWS SDK for Go's `s3manager`, and `s3iface`
packages. These packages make the s3manager packages's GetBucketRegion
utility available for discovering a S3 bucket's locations.

These packages are used by PR #14221.

Update CHANGELOG for #14221 and other minor formatting fixes

refactor trimTrailingPeriod method
@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Aug 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees

@breathingdust breathingdust

@maryelizbeth maryelizbeth

Labels
documentation Introduces or discusses updates to documentation. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.0.0
5 participants
@ewbankkit @reyescameron17 @breathingdust @anGie44 @maryelizbeth