Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a aws_rds_cluster_instance data source or add cluster type info to the aws_rds_instance data source #9739

Closed
digitalfiz opened this issue Aug 12, 2019 · 3 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.

Comments

@digitalfiz
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Right now it is impossible to get enough info for a rds instance to know if it is a reader or writer because the aws_db_instance data source does not return things like writer=true|false.

So can we either add a new data source for aws_rds_cluster_instance or just add some more return values to aws_db_instance. i am not sure what you guys normally do when there are very similar resources with slightly different properties.

New or Affected Resource(s)

  • aws_rds_cluster_instance
  • aws_db_instance

Potential Terraform Configuration

Something close to what I am attempting:

data "aws_db_instance" "dbs" {
  count                  = length(module.stack.aurora_instance_ids)
  db_instance_identifier = module.stack.aurora_instance_ids[count.index]
}

output "readers" {
  value = [for i, z in data.aws_db_instance.dbs.* : z.id if z.writer == False]
}

output "writer" {
  value = [for i, z in data.aws_db_instance.dbs.* : z.id if z.wrtier == True][0]
}

This is not working code but the idea is there.

@digitalfiz digitalfiz added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 12, 2019
@ghost ghost added the service/rds Issues and PRs that pertain to the rds service. label Aug 12, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 12, 2019
@github-actions
Copy link

github-actions bot commented Aug 2, 2021

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Aug 2, 2021
@github-actions github-actions bot closed this as completed Sep 2, 2021
@digitalfiz
Copy link
Contributor Author

Well that's unfortunate....

@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.
Projects
None yet
Development

No branches or pull requests

2 participants