Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lex bot alias data source and resoruce #8919

Merged
merged 4 commits into from
Oct 5, 2020
Merged

Add Lex bot alias data source and resoruce #8919

merged 4 commits into from
Oct 5, 2020

Conversation

jzbruno
Copy link
Contributor

@jzbruno jzbruno commented Jun 10, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #905 and split from PR #2616

Release note for CHANGELOG:

FEATURES:
* **New Data Source:** `aws_lex_bot_alias`
* **New Resource:** `aws_lex_bot_alias`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDataSourceAwsLexBotAlias'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccDataSourceAwsLexBotAlias -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccDataSourceAwsLexBotAlias
--- SKIP: TestAccDataSourceAwsLexBotAlias (0.00s)
    data_source_aws_lex_bot_alias_test.go:12: The Lex intent PR and Lex bot PR must be merged for this test to pass. https://github.com/terraform-providers/terraform-provider-aws/pull/8917 https://github.com/terraform-providers/terraform-provider-aws/pull/8918
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	0.042s

$ make testacc TESTARGS='-run=TestAccAwsLexBotAlias'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAwsLexBotAlias -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAwsLexBotAlias
--- SKIP: TestAccAwsLexBotAlias (0.00s)
    resource_aws_lex_bot_alias_test.go:15: The Lex intent PR and Lex bot PR must be merged for this test to pass. https://github.com/terraform-providers/terraform-provider-aws/pull/8917 https://github.com/terraform-providers/terraform-provider-aws/pull/8918
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	0.040s

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/lexmodels Issues and PRs that pertain to the lexmodels service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Jun 10, 2019
@nywilken nywilken added this to the v2.16.0 milestone Jun 10, 2019
@nywilken nywilken self-assigned this Jun 20, 2019
@nywilken nywilken modified the milestones: v2.16.0, v2.17.0, v2.18.0 Jun 20, 2019
@jzbruno jzbruno requested a review from a team June 24, 2019 05:52
@bflad bflad modified the milestones: v2.18.0, v2.19.0, v2.20.0 Jul 5, 2019
@nywilken nywilken modified the milestones: v2.20.0, v2.21.0 Jul 19, 2019
@bflad bflad modified the milestones: v2.21.0, v2.22.0 Jul 25, 2019
@nywilken
Copy link
Contributor

@jzbruno, and folks following along, my apologies for the longer than normal delays on pushing forward this feature. I haven't had the chance to devote the needed time get the other pull-requests into a mergable state 😳 I appreciate your patience as we continue to work through this resource.

While I can't say that it will get into the next upcoming release(s), I can say that the resource is still a priority for us.

To not give false expectations around the release of this resource I am going to remove the milestone. But let's coordinate on when would be ideal to continue pushing forward. If you find that your availability has also slowed please let me know if we should consider having another community member or the maintainers take over the pull-request(s).

Cheers

@nywilken nywilken removed this from the v2.22.0 milestone Jul 29, 2019
@jzbruno
Copy link
Contributor Author

jzbruno commented Jul 30, 2019

@nywilken I can continue to work on this. I believe this is ready for further review.

@aeschright aeschright added the new-resource Introduces a new resource. label Aug 19, 2019
@jzbruno
Copy link
Contributor Author

jzbruno commented Aug 27, 2019

@nywilken This one is ready for review.

@nywilken nywilken removed their assignment Oct 10, 2019
@maryelizbeth maryelizbeth added this to the Roadmap milestone May 20, 2020
@gdavison gdavison self-assigned this Jun 8, 2020
This was referenced Sep 7, 2020
@gdavison gdavison added the waiting-response Maintainers are waiting on response from community or contributor. label Sep 15, 2020
@jzbruno
Copy link
Contributor Author

jzbruno commented Sep 28, 2020

@gdavison Just FYI, I am updating this PR with the same review comments from the other Lex resource PRs, including adding the new fields.

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 28, 2020
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Sep 28, 2020
@jzbruno
Copy link
Contributor Author

jzbruno commented Sep 28, 2020

@gdavison Ok. When the intent and bot PRs are merged this one is ready for review too.

~/src/github/terraform-providers/terraform-provider-aws $ make testacc TESTARGS='-run=TestAcc.*LexBotAlias.*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAcc.*LexBotAlias.* -timeout 120m
=== RUN   TestAccDataSourceAwsLexBotAlias_basic
=== PAUSE TestAccDataSourceAwsLexBotAlias_basic
=== RUN   TestAccAwsLexBotAlias_basic
=== PAUSE TestAccAwsLexBotAlias_basic
=== RUN   TestAccAwsLexBotAlias_botVersion
=== PAUSE TestAccAwsLexBotAlias_botVersion
=== RUN   TestAccAwsLexBotAlias_conversationLogsText
=== PAUSE TestAccAwsLexBotAlias_conversationLogsText
=== RUN   TestAccAwsLexBotAlias_conversationLogsAudio
=== PAUSE TestAccAwsLexBotAlias_conversationLogsAudio
=== RUN   TestAccAwsLexBotAlias_description
=== PAUSE TestAccAwsLexBotAlias_description
=== RUN   TestAccAwsLexBotAlias_disappears
=== PAUSE TestAccAwsLexBotAlias_disappears
=== CONT  TestAccDataSourceAwsLexBotAlias_basic
=== CONT  TestAccAwsLexBotAlias_conversationLogsAudio
=== CONT  TestAccAwsLexBotAlias_disappears
=== CONT  TestAccAwsLexBotAlias_description
=== CONT  TestAccAwsLexBotAlias_botVersion
=== CONT  TestAccAwsLexBotAlias_conversationLogsText
=== CONT  TestAccAwsLexBotAlias_basic
=== CONT  TestAccAwsLexBotAlias_disappears
    resource_aws_lex_bot_alias_test.go:218: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAwsLexBotAlias_conversationLogsAudio (76.31s)
--- PASS: TestAccAwsLexBotAlias_conversationLogsText (78.98s)
--- PASS: TestAccAwsLexBotAlias_botVersion (82.69s)
--- PASS: TestAccDataSourceAwsLexBotAlias_basic (86.27s)
--- PASS: TestAccAwsLexBotAlias_basic (91.03s)
--- PASS: TestAccAwsLexBotAlias_description (94.00s)
--- PASS: TestAccAwsLexBotAlias_disappears (98.64s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	100.184s

Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccDataSourceAwsLexBotAlias_basic (40.97s)
--- PASS: TestAccAwsLexBotAlias_botVersion (76.18s)
--- PASS: TestAccAwsLexBotAlias_disappears (158.05s)
--- PASS: TestAccAwsLexBotAlias_basic (194.58s)
--- PASS: TestAccAwsLexBotAlias_conversationLogsAudio (197.02s)
--- PASS: TestAccAwsLexBotAlias_conversationLogsText (198.77s)
--- PASS: TestAccAwsLexBotAlias_conversationLogsBoth (203.08s)
--- PASS: TestAccAwsLexBotAlias_description (259.16s)

@gdavison gdavison modified the milestones: Roadmap, v3.10.0 Oct 5, 2020
gdavison added a commit that referenced this pull request Oct 5, 2020
@gdavison gdavison merged commit 58212fa into hashicorp:master Oct 5, 2020
@ghost
Copy link

ghost commented Oct 9, 2020

This has been released in version 3.10.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/lexmodels Issues and PRs that pertain to the lexmodels service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants