Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_s3_bucket_object: Add support for S3 Object Lock legal holds #7158

Closed
ewbankkit opened this issue Jan 16, 2019 · 6 comments · Fixed by #9942
Closed

r/aws_s3_bucket_object: Add support for S3 Object Lock legal holds #7158

ewbankkit opened this issue Jan 16, 2019 · 6 comments · Fixed by #9942
Assignees
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service.
Milestone

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Jan 16, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Now that S3 buckets support Amazon S3 Object Lock (#6634 & #6872), add support for S3 object legal holds to the aws_s3_bucket_object resource and data source.

@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 16, 2019
@ewbankkit
Copy link
Contributor Author

@ewbankkit
Copy link
Contributor Author

Suggested syntax:

resource "aws_s3_bucket_object" "foo" {
  bucket = "my-versioning-bucket"
  key    = "important-data.txt"

  legal_hold {
    status = "ON"
  }
}

@ewbankkit
Copy link
Contributor Author

With the new PR I am going with a simplified syntax that is more in line with the S3 API:

resource "aws_s3_bucket_object" "example" {
  object_lock_legal_hold_status = "ON"
}

@nywilken
Copy link
Contributor

The enhancement to the aws_s3_bucket_object resource has been merged and will be released with version 2.29.0 of the Terraform AWS provider.

@nywilken nywilken added this to the v2.29.0 milestone Sep 18, 2019
@nywilken nywilken added the documentation Introduces or discusses updates to documentation. label Sep 18, 2019
@ghost
Copy link

ghost commented Sep 20, 2019

This has been released in version 2.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service.
Projects
None yet
3 participants