Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Lambda support missing for dotnetcore2.1. #5148

Closed
CasperSkydt opened this issue Jul 11, 2018 · 5 comments · Fixed by #5150
Closed

AWS Lambda support missing for dotnetcore2.1. #5148

CasperSkydt opened this issue Jul 11, 2018 · 5 comments · Fixed by #5150
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/lambda Issues and PRs that pertain to the lambda service.
Milestone

Comments

@CasperSkydt
Copy link

Is getting the following error:

expected runtime to be one of [dotnetcore1.0 dotnetcore2.0 go1.x java8 nodejs4.3 nodejs4.3-edge nodejs6.10 nodejs8.10 python2.7 python3.6], got dotnetcore2.1

Not being familiar with go, i'm guessing this is the problem though:

https://github.com/terraform-providers/terraform-provider-aws/blob/master/aws/resource_aws_lambda_function.go#L106

Its missing dotnetcore2.1

https://aws.amazon.com/about-aws/whats-new/2018/06/lambda-supports-dotnetcore-twopointone/

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

New or Affected Resource(s)

  • aws_XXXXX

Potential Terraform Configuration

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.

References

  • #0000
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/lambda Issues and PRs that pertain to the lambda service. labels Jul 11, 2018
@bflad
Copy link
Contributor

bflad commented Jul 11, 2018

Pull request submitted to add dotnetcore2.1 to the runtime argument validation: #5150

@bflad bflad added this to the v1.27.0 milestone Jul 11, 2018
@bflad
Copy link
Contributor

bflad commented Jul 11, 2018

This has been merged in and will release with version 1.27.0 of the AWS provider, likely later today.

@CasperSkydt
Copy link
Author

That was really fast, awesome work, and thanks for the help.

@bflad
Copy link
Contributor

bflad commented Jul 11, 2018

This has been released in version 1.27.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/lambda Issues and PRs that pertain to the lambda service.
Projects
None yet
2 participants