Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New DataSource: aws_dx_gateway #4983

Closed
sleterrier opened this issue Jun 26, 2018 · 5 comments · Fixed by #4988
Closed

New DataSource: aws_dx_gateway #4983

sleterrier opened this issue Jun 26, 2018 · 5 comments · Fixed by #4988
Labels
new-data-source Introduces a new data source. service/directconnect Issues and PRs that pertain to the directconnect service.
Milestone

Comments

@sleterrier
Copy link

sleterrier commented Jun 26, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Following the addition of aws_dx_gateway and aws_dx_gateway_assocation resources, it would very useful to have access to an 'aws_dx_gateway' DataSource to allow for dynamic and variable based configurations. Particularly relevant in a multi regions/accounts scenario. See example below.

New or Affected Resource(s)

  • aws_dx_gateway
  • aws_dx_gateway_assocation

Potential Terraform Configuration

# Global  role
resource "aws_dx_gateway" "test" {
  name            = "${var.dxgw_name}"
  amazon_side_asn = "${ ... }"
}

# Regional role
data "aws_dx_gateway" "test" {
  count    = "${var.is_aws_dx_enable ? 1 : 0}"
  name     = "${var.dxgw_name}"
}

resource "aws_vpn_gateway" "test" {
  vpc_id = "${aws_vpc.test.id}"
}

resource "aws_dx_gateway_association" "test" {
  count          = "${var.is_aws_dx_enable ? 1 : 0}"
  dx_gateway_id  = "${data.aws_dx_gateway.test.id}"
  vpn_gateway_id = "${aws_vpn_gateway.test.id}"
}

References

@paultyng paultyng added new-data-source Introduces a new data source. service/directconnect Issues and PRs that pertain to the directconnect service. labels Jun 26, 2018
@bflad
Copy link
Contributor

bflad commented Jun 26, 2018

I can submit a pull request for this today or tomorrow. 👍

@bflad
Copy link
Contributor

bflad commented Jun 26, 2018

Pull request submitted: #4988

@bflad
Copy link
Contributor

bflad commented Jun 26, 2018

A new aws_dx_gateway data source has been merged and will release with version 1.25.0 of the AWS provider, likely tomorrow.

@bflad bflad added this to the v1.25.0 milestone Jun 26, 2018
@bflad
Copy link
Contributor

bflad commented Jun 27, 2018

This has been released in version 1.25.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-data-source Introduces a new data source. service/directconnect Issues and PRs that pertain to the directconnect service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants