r/aws_rds_integration: add data_filter argument

[jar-b]

Description

This argument is optional and computed, as AWS sets a default value of include: *.* when omitted.

Relations

Closes #39762

References

• https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_CreateIntegration.html
• https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/zero-etl.filtering.html

Output from Acceptance Testing

% make testacc PKG=rds TESTS=TestAccRDSIntegration_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSIntegration_'  -timeout 360m
2025/01/07 11:18:46 Initializing Terraform AWS Provider...

--- PASS: TestAccRDSIntegration_basic (1775.26s)
--- PASS: TestAccRDSIntegration_disappears (1807.05s)
--- PASS: TestAccRDSIntegration_optional (2079.73s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        2085.031s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

I also ran a one-time acceptance test to confirm adding this "force new" argument won't cause existing configurations to be re-created. I opted not to include this in the PR because these tests take quite a long time to run and was mostly just a sanity check versus some behavior we'd want to continually check.

func TestAccRDSIntegration_dataFilterUpdate(t *testing.T) {
	if testing.Short() {
		t.Skip("skipping long-running test in short mode")
	}

	ctx := acctest.Context(t)
	var integration awstypes.Integration
	rName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
	resourceName := "aws_rds_integration.test"

	resource.ParallelTest(t, resource.TestCase{
		PreCheck:     func() { acctest.PreCheck(ctx, t) },
		ErrorCheck:   acctest.ErrorCheck(t, names.RDSServiceID),
		CheckDestroy: testAccCheckIntegrationDestroy(ctx),
		Steps: []resource.TestStep{
			{
				ExternalProviders: map[string]resource.ExternalProvider{
					"aws": {
						Source:            "hashicorp/aws",
						VersionConstraint: "5.81.0",
					},
				},
				Config: testAccIntegrationConfig_baseClusterWithInstance(rName),
				Check: resource.ComposeTestCheckFunc(
					waitUntilDBInstanceRebooted(ctx, rName),
				),
			},
			{
				ExternalProviders: map[string]resource.ExternalProvider{
					"aws": {
						Source:            "hashicorp/aws",
						VersionConstraint: "5.81.0",
					},
				},
				Config: testAccIntegrationConfig_basic(rName),
				Check: resource.ComposeAggregateTestCheckFunc(
					testAccCheckIntegrationExists(ctx, resourceName, &integration),
					resource.TestCheckResourceAttr(resourceName, "integration_name", rName),
					// resource.TestCheckResourceAttr(resourceName, "data_filter", "include: *.*"), // shouldn't exist yet
					resource.TestCheckResourceAttrPair(resourceName, "source_arn", "aws_rds_cluster.test", names.AttrARN),
					resource.TestCheckResourceAttr(resourceName, acctest.CtTagsPercent, "0"),
					resource.TestCheckResourceAttrPair(resourceName, names.AttrTargetARN, "aws_redshiftserverless_namespace.test", names.AttrARN),
				),
			},
			{
				ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories,
				Config:                   testAccIntegrationConfig_basic(rName),
				Check: resource.ComposeAggregateTestCheckFunc(
					testAccCheckIntegrationExists(ctx, resourceName, &integration),
					resource.TestCheckResourceAttr(resourceName, "integration_name", rName),
					resource.TestCheckResourceAttr(resourceName, "data_filter", "include: *.*"),
					resource.TestCheckResourceAttrPair(resourceName, "source_arn", "aws_rds_cluster.test", names.AttrARN),
					resource.TestCheckResourceAttr(resourceName, acctest.CtTagsPercent, "0"),
					resource.TestCheckResourceAttrPair(resourceName, names.AttrTargetARN, "aws_redshiftserverless_namespace.test", names.AttrARN),
				),
			},
		},
	})
}

% make testacc PKG=rds TESTS=TestAccRDSIntegration_dataFilterUpdate
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSIntegration_dataFilterUpdate'  -timeout 360m
2025/01/07 15:15:56 Initializing Terraform AWS Provider...
=== RUN   TestAccRDSIntegration_dataFilterUpdate
=== PAUSE TestAccRDSIntegration_dataFilterUpdate
=== CONT  TestAccRDSIntegration_dataFilterUpdate
--- PASS: TestAccRDSIntegration_dataFilterUpdate (1998.08s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        2003.400s

[nam054]

LGTM 🚀

> make testacc PKG=rds TESTS=TestAccRDSIntegration_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSIntegration_'  -timeout 360m
2025/01/08 12:38:36 Initializing Terraform AWS Provider...
=== RUN   TestAccRDSIntegration_basic
=== PAUSE TestAccRDSIntegration_basic
=== RUN   TestAccRDSIntegration_disappears
=== PAUSE TestAccRDSIntegration_disappears
=== RUN   TestAccRDSIntegration_optional
=== PAUSE TestAccRDSIntegration_optional
=== CONT  TestAccRDSIntegration_basic
=== CONT  TestAccRDSIntegration_optional
=== CONT  TestAccRDSIntegration_disappears
--- PASS: TestAccRDSIntegration_disappears (1903.39s)
--- PASS: TestAccRDSIntegration_basic (1913.19s)
--- PASS: TestAccRDSIntegration_optional (2105.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	2112.083s

[trejas]

@jar-b - We are waiting on this feature for a blocked deployment. Just curious, how long after the milestone due dates does the team usually release the associated provider version?

I see that 5.83.0 milesetone is due today.

[github-actions]

This functionality has been released in v5.83.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!